Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(code): Increase timeouts by the configured delta when they elapse #207

Merged
merged 2 commits into from
Jun 5, 2024

Conversation

romac
Copy link
Member

@romac romac commented Jun 4, 2024

Timeouts values are reset between each height.

@romac romac requested a review from ancazamfir June 4, 2024 14:16
Copy link

codecov bot commented Jun 4, 2024

Codecov Report

Attention: Patch coverage is 77.19298% with 13 lines in your changes missing coverage. Please review.

Project coverage is 83.09%. Comparing base (9bdb9f0) to head (dc45625).

Files Patch % Lines
code/actors/src/timers.rs 75.93% 13 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #207      +/-   ##
==========================================
- Coverage   83.17%   83.09%   -0.07%     
==========================================
  Files          67       67              
  Lines        4812     4850      +38     
==========================================
+ Hits         4002     4030      +28     
- Misses        810      820      +10     
Flag Coverage Δ
integration 83.09% <77.19%> (-0.08%) ⬇️
mbt 17.94% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@ancazamfir ancazamfir left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm! 🥳

@romac romac merged commit f1f1e6d into main Jun 5, 2024
11 of 12 checks passed
@romac romac deleted the romac/timeout-delta branch June 5, 2024 05:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants