Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(code): Add ValueBuilder test params to the config #206

Merged
merged 1 commit into from
Jun 5, 2024

Conversation

romac
Copy link
Member

@romac romac commented Jun 4, 2024

These values can be overridden using the following environment variables:

  • MALACHITE__TEST__TXS_PER_PART
  • MALACHITE__TEST__TIME_ALLOWANCE_FACTOR
  • MALACHITE__TEST__EXEC_TIME_PER_PART

Timeouts can also be overridden using the following environment variables:

  • MALACHITE__CONSENSUS__TIMEOUT_PROPOSE
  • MALACHITE__CONSENSUS__TIMEOUT_PREVOTE
  • MALACHITE__CONSENSUS__TIMEOUT_PRECOMMIT
  • MALACHITE__CONSENSUS__TIMEOUT_COMMIT

These values can be overriden using the following environment variables:
- Override with MALACHITE__TEST__TXS_PER_PART
- MALACHITE__TEST__TIME_ALLOWANCE_FACTOR
- MALACHITE__TEST__EXEC_TIME_PER_PART

Timeouts can also be overriden using the following environment variables:
- MALACHITE__CONSENSUS__TIMEOUT_PROPOSE
- MALACHITE__CONSENSUS__TIMEOUT_PREVOTE
- MALACHITE__CONSENSUS__TIMEOUT_PRECOMMIT
- MALACHITE__CONSENSUS__TIMEOUT_COMMIT
@romac romac requested a review from ancazamfir June 4, 2024 14:09
Copy link

codecov bot commented Jun 4, 2024

Codecov Report

Attention: Patch coverage is 42.85714% with 36 lines in your changes missing coverage. Please review.

Project coverage is 83.29%. Comparing base (2ae7f78) to head (a1ea6a2).

Files Patch % Lines
code/cli/src/args.rs 0.00% 36 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #206      +/-   ##
==========================================
- Coverage   83.83%   83.29%   -0.54%     
==========================================
  Files          67       67              
  Lines        4779     4834      +55     
==========================================
+ Hits         4006     4026      +20     
- Misses        773      808      +35     
Flag Coverage Δ
integration 83.28% <42.86%> (-0.55%) ⬇️
mbt 17.94% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@ancazamfir ancazamfir left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm! 🚀

@ancazamfir ancazamfir merged commit 16b589f into main Jun 5, 2024
12 of 13 checks passed
@ancazamfir ancazamfir deleted the romac/value-builder-config branch June 5, 2024 00:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants