chore(code): Resolve cyclic dependency between Consensus and ProposalBuilder actor
#199
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## anca/mempool_for_testing #199 +/- ##
============================================================
- Coverage 84.74% 84.64% -0.10%
============================================================
Files 66 66
Lines 4797 4778 -19
============================================================
- Hits 4065 4044 -21
- Misses 732 734 +2
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
romac
added a commit
that referenced
this pull request
Jun 4, 2024
…value builder (#191) * Initial commit for mempool gossip * Add transaction * Build value by streaming mempool tx-es. Adds basic sync at startup based on number of peers. Uses different peerID sets for consensus and mempool in an attempt to create separate networks (not there yet). UTs are not yet fixed. * Enqueue messages for higher height for replay * Cargo fmt * Remove dbg, add back no_std for round * Add back no_std for common. * Wait for 2 + 2 peers * Fix UTs * Turn a couple assertions in the driver into proper errors * Update `driver_steps_not_proposer_other_height` test to expect an error * Fix coverage on latest nightly * Remove startup hack now that #190 has landed * feat(code): Improve reliability of node startup and gossip (#192) * Use random identity for mempool gossip * Only accept messages from peers using the same protocol * Formatting * Enable logging in tests * Increase timeout * Another attempt to fix test * Comment out dead code * Revert timeout change * Run tests on macOS as well * Use Ubuntu 24 * Revert "Use Ubuntu 24" This reverts commit f5d7f88. * Use TCP transport instead of QUIC * Send a Ready message to all peers, and only start consensus when we got enough of those * Disable peer filtering based on protocol version * Remove Ready message * Fix bug in gossip mempool * Disable peer filtering based on protocol version again * Switch back to QUIC * Cleanup * No need for different identities if we do not blacklist peers * Remove commented out code * No need to act on expired mDNS entries * Send PeerDisconnected event to handle when a peer unsubscribes * No need to test on macOS anymore * Cleanup * Fix "API rate limit exceed" error when installing `protoc` * Fix compilation error and some merge issues * feat(code): Add transaction streaming and block part gossip (#197) * Add gossip blockpart channel and BlockPart trait and test impl * Sign and gossip block parts, receive them, validate, send to proposal builder * Value builder now streams txes for a fraction of propose timeout * Add constants for hardcoded values * Fix proposal builder initialization and tweak some constants * Gossip block part before processing it * Spelling * Create and gossip BlockMetadata. Revert the consensus proposal value to be the block hash (or ValueId). * Process received block parts, send valueId and valid to consensus actor. Multiplex proposal and last block part, pass valid from the latter. Check if all parts are present when a proposal is received, otherwise queue. Implement a temporary store for block parts. * Small cleanup and spelling * Cleanup * chore(code): Resolve cyclic dependency between `Consensus` and `ProposalBuilder` actor (#199) * Rename field for consistency * Resolve cyclic dependency between Consensus and ProposalBuilder actor * Add forgotted return for invalid prposal signatures. Some cleanup and TODO updates. * Cleanup * Merge `CAL` actor with `ProposalBuilder` actor and rename to `Host` actor (#200) * Remove CAL actor and move `GetValidatorSet` into `ProposalBuilder` * Rename `ProposalBuilder` actor to `Host` * Make `PartStore` context-generic and move into its own module (#201) * Use persistent peers instead of mdns (#204) * Wire up `persistent_peers` from config to both gossip layers * simplified index command to only generate configs when init command is run * Cleanup dialing of persistent peers * Only add explicit peers when their protocol version matches * Cleanup * Fix args parsing test * Use random base ports per test * Formatting --------- Co-authored-by: Greg Szabo <greg@philosobear.com> * Add `testnet` command, and clean up CLI (#205) * removed index parameter, added testnet command, simplified init command * Update help message * Remove `--config`, `--genesis` and `--private-key` options * Unpretty private key bytes * Log output in `testnet` command * Use CometBFT-compatible format for `priv_validator_key.json` file * Add test for `testnet` command --------- Co-authored-by: Greg Szabo <greg@philosobear.com> --------- Co-authored-by: Anca Zamfir <zamfiranca@gmail.com> Co-authored-by: Greg Szabo <16846635+greg-szabo@users.noreply.github.com> Co-authored-by: Anca Zamfir <ancazamfir@users.noreply.github.com> Co-authored-by: Greg Szabo <greg@philosobear.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes: #XXX
PR author checklist