-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(code): Actor-based node implementation #167
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Amazing work @romac!
It seems that we don't check the vote heights when counting and we mix votes from different heights but same round.
|
I see messages received in a different/ reverse order than sent. It should be fine for consensus messages but was wondering why.
receiver:
|
Not sure. Messages are sent in order through GossipSub, but I don't think that GossipSub provides any message ordering guarantees. Will look more into it. |
Good catch! I did the same check for proposals as well: 340d6b4 |
Maybe we open a separate issue for this so we can merge this PR? |
Closes: #XXX
To start a node, where
INDEX
is0
(initial proposer),1
or2
Follow-up tasks
init
andstart
commandsPR author checklist