Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

code: Remove signing and signature verification from the driver #121

Merged
merged 2 commits into from
Dec 18, 2023
Merged

code: Remove signing and signature verification from the driver #121

merged 2 commits into from
Dec 18, 2023

Conversation

romac
Copy link
Member

@romac romac commented Dec 13, 2023 •
edited
Loading

Closes: #119

To keep things simple and for a better separation of concerns, the driver should only see votes and proposals whose signature has already been verified to be valid.

@romac romac requested a review from ancazamfir December 13, 2023 11:22
@codecov Codecov
Copy link

codecov bot commented Dec 14, 2023

Codecov upload limit reached ⚠️

This org is currently on the free Basic Plan; which includes 250 free private repo uploads each rolling month. This limit has been reached and additional reports cannot be generated. For unlimited uploads, upgrade to our pro plan.

Do you have questions or need help? Connect with our sales team today at sales@codecov.io

@romac romac merged commit 5d0577f into main Dec 18, 2023
9 checks passed
@romac romac deleted the romac/move-signing branch December 18, 2023 10:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ancazamfir ancazamfir Awaiting requested review from ancazamfir

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

code: Move signing and signature verification outside of the driver
1 participant
@romac