code: Multiplexer refactoring #110
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov upload limit reached
|
romac
force-pushed
the
romac/mixer-reorg
branch
2 times, most recently
from
0ea0b64 to
58b2fcb
Compare
romac
force-pushed
the
romac/mixer-reorg
branch
from
b077737 to
6c8f27b
Compare
ancazamfir
approved these changes
Dec 7, 2023
romac
added a commit
that referenced
this pull request
Dec 8, 2023
* Add tests (all failing) for polka occuring in propose step * Report coverage even when tests fail * Split event multiplexing into its own function * Small refactor * wip: Add mixer on step changes * Add case in step change mixer for polka value * Revert misakenly deleted comment * Process pending inputs automatically after processing an input (#108) * Cleanup * Naming * Multiplexer refactoring (#110) * Sketch for mixer reorg * Small cleanup * No fail fast on tests * Emit thresholds even when there are no proposals * Debugging * Fix emitted inputs when no proposal * Cleanup * Restore insertion of proposal * Remove debug statements --------- Co-authored-by: Anca Zamfir <anca@informal.systems> * Only store a single proposal in the driver (#107) * Only store a single proposal * Check proposal round matches input round * Remove dead code * Turn `multiplex_` functions into methods of the `Driver` * Some cleanup * Re-enable `no_std` in driver --------- Co-authored-by: Anca Zamfir <anca@informal.systems>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.