Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

code: Add multiplexer #106

Merged
merged 17 commits into from
Dec 8, 2023
Merged

code: Add multiplexer #106

merged 17 commits into from
Dec 8, 2023

Conversation

romac
Copy link
Member

@romac romac commented Dec 6, 2023 •
edited
Loading

Closes: #96

@codecov Codecov
Copy link

codecov bot commented Dec 6, 2023 •
edited
Loading

Codecov upload limit reached ⚠️

This org is currently on the free Basic Plan; which includes 250 free private repo uploads each rolling month. This limit has been reached and additional reports cannot be generated. For unlimited uploads, upgrade to our pro plan.

Do you have questions or need help? Connect with our sales team today at sales@codecov.io

romac
romac commented Dec 6, 2023
View reviewed changes
Code/test/tests/driver_extra.rs Outdated Show resolved Hide resolved
@romac romac changed the title code: Add mixer on step change code: Add multiplexer on step change Dec 6, 2023
romac
romac commented Dec 6, 2023
View reviewed changes
Code/driver/src/lib.rs Outdated Show resolved Hide resolved
romac
romac commented Dec 6, 2023
View reviewed changes
Code/driver/src/lib.rs Outdated Show resolved Hide resolved
ancazamfir
ancazamfir reviewed Dec 6, 2023
View reviewed changes
Code/driver/src/mixer.rs Outdated Show resolved Hide resolved
@romac romac mentioned this pull request Dec 7, 2023
Closed
@romac romac changed the base branch from anca/mixer-tests to main December 7, 2023 09:13
romac and others added 3 commits December 7, 2023 10:13
@romac
Merge branch 'main' into romac/mixer
9d990fb
@romac
Naming
99becf5
@romac @ancazamfir
Multiplexer refactoring (#110)
5412436 
* Sketch for mixer reorg

* Small cleanup

* No fail fast on tests

* Emit thresholds even when there are no proposals

* Debugging

* Fix emitted inputs when no proposal

* Cleanup

* Restore insertion of proposal

* Remove debug statements

---------

Co-authored-by: Anca Zamfir <zamfiranca@gmail.com>
@romac romac marked this pull request as ready for review December 7, 2023 16:33
@romac romac changed the title code: Add multiplexer on step change code: Add multiplexer Dec 7, 2023
romac and others added 4 commits December 7, 2023 17:53
@romac
Merge branch 'main' into romac/mixer
aea77cb
@romac
Only store a single proposal in the driver (#107)
6ffee0b 
* Only store a single proposal

* Check proposal round matches input round

* Remove dead code

* Turn `multiplex_` functions into methods of the `Driver`
@ancazamfir
Some cleanup
a3c2d4c
@romac
Re-enable no_std in driver
01ac4c4
@romac romac merged commit ccdbe8a into main Dec 8, 2023
6 checks passed
@romac romac deleted the romac/mixer branch December 8, 2023 10:53
@romac romac mentioned this pull request Dec 8, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ancazamfir ancazamfir ancazamfir left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

code: Allow driver to feed multiple inputs to round state machine
2 participants
@romac @ancazamfir