-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
spec: adding step change #104
Conversation
Codecov upload limit reached
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me.
This PR adds the logic that checks checks whether a change in the consensus step variable (e.g., from prevote to precommit) enabled a consensus input that needs to be fired.
StepChange
called by the driver to see whether consensus needs to be called after the step has changed (e.g., from prevote to precommit) and calls it if necessarydriverLogic
) that records a step changeFor later reference, here is the Google doc by Anca where she listed the cases.