Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

spec: adding step change #104

Merged
merged 15 commits into from
Dec 12, 2023
Merged

spec: adding step change #104

merged 15 commits into from
Dec 12, 2023

Conversation

josef-widder
Copy link
Member

@josef-widder josef-widder commented Dec 6, 2023

This PR adds the logic that checks checks whether a change in the consensus step variable (e.g., from prevote to precommit) enabled a consensus input that needs to be fired.

  • Add a function StepChange called by the driver to see whether consensus needs to be called after the step has changed (e.g., from prevote to precommit) and calls it if necessary
  • Add a wrapper around the old driver function (now called driverLogic) that records a step change
  • Add branches that detect a step change, and call

For later reference, here is the Google doc by Anca where she listed the cases.

Copy link

codecov bot commented Dec 6, 2023

Codecov upload limit reached ⚠️

This org is currently on the free Basic Plan; which includes 250 free private repo uploads each rolling month. This limit has been reached and additional reports cannot be generated. For unlimited uploads, upgrade to our pro plan.

Do you have questions or need help? Connect with our sales team today at sales@codecov.io

@josef-widder josef-widder marked this pull request as ready for review December 12, 2023 11:30
@josef-widder josef-widder requested review from romac and hvanz December 12, 2023 12:58
@josef-widder josef-widder mentioned this pull request Dec 12, 2023
10 tasks
Copy link
Member

@hvanz hvanz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@romac romac merged commit 3005a28 into main Dec 12, 2023
8 checks passed
@romac romac deleted the josef/addStepInput branch December 12, 2023 15:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants