Rename GetEarliestBlockHeight to GetHistoryMinHeight

informalsystems · Dec 17, 2024 · e7e4b20 · e7e4b20
1 parent 30de7ea
commit e7e4b20
Show file tree

Hide file tree

Showing 7 changed files with 10 additions and 12 deletions.
diff --git a/code/crates/app-channel/src/channel.rs b/code/crates/app-channel/src/channel.rs
@@ -52,7 +52,7 @@ pub enum AppMsg<Ctx: Context> {
     },
 
     /// Request the earliest block height in the block store
-    GetEarliestBlockHeight { reply: Reply<Ctx::Height> },
+    GetHistoryMinHeight { reply: Reply<Ctx::Height> },
 
     /// ProposalPart received <-- consensus <-- gossip
     ReceivedProposalPart {

diff --git a/code/crates/app-channel/src/connector.rs b/code/crates/app-channel/src/connector.rs
@@ -112,11 +112,11 @@ where
                     .await?
             }
 
-            HostMsg::GetEarliestBlockHeight { reply_to } => {
+            HostMsg::GetHistoryMinHeight { reply_to } => {
                 let (reply, rx) = oneshot::channel();
 
                 self.sender
-                    .send(AppMsg::GetEarliestBlockHeight { reply })
+                    .send(AppMsg::GetHistoryMinHeight { reply })
                     .await?;
 
                 reply_to.send(rx.await?)?;

diff --git a/code/crates/engine/src/consensus.rs b/code/crates/engine/src/consensus.rs
@@ -708,7 +708,7 @@ where
     }
 
     async fn get_history_min_height(&self) -> Result<Ctx::Height, ActorProcessingErr> {
-        ractor::call!(self.host, |reply_to| HostMsg::GetEarliestBlockHeight {
+        ractor::call!(self.host, |reply_to| HostMsg::GetHistoryMinHeight {
             reply_to
         })
         .map_err(|e| eyre!("Failed to get earliest block height: {e:?}").into())

diff --git a/code/crates/engine/src/host.rs b/code/crates/engine/src/host.rs
@@ -75,7 +75,7 @@ pub enum HostMsg<Ctx: Context> {
     },
 
     /// Request the earliest block height in the block store
-    GetEarliestBlockHeight { reply_to: RpcReplyPort<Ctx::Height> },
+    GetHistoryMinHeight { reply_to: RpcReplyPort<Ctx::Height> },
 
     /// ProposalPart received <-- consensus <-- gossip
     ReceivedProposalPart {

diff --git a/code/crates/engine/src/sync.rs b/code/crates/engine/src/sync.rs
@@ -204,10 +204,10 @@ where
     }
 
     async fn get_history_min_height(&self) -> Result<Ctx::Height, ActorProcessingErr> {
-        ractor::call!(self.host, |reply_to| HostMsg::GetEarliestBlockHeight {
+        ractor::call!(self.host, |reply_to| HostMsg::GetHistoryMinHeight {
             reply_to
         })
-        .map_err(|e| eyre!("Failed to get earliest block height: {e:?}").into())
+        .map_err(|e| eyre!("Failed to get earliest history height: {e:?}").into())
     }
 
     async fn handle_effect(

diff --git a/code/crates/starknet/host/src/actor.rs b/code/crates/starknet/host/src/actor.rs
@@ -126,9 +126,7 @@ impl Host {
                 proposer,
             } => on_started_round(state, height, round, proposer).await,
 
-            HostMsg::GetEarliestBlockHeight { reply_to } => {
-                on_get_history_min_height(state, reply_to)
-            }
+            HostMsg::GetHistoryMinHeight { reply_to } => on_get_history_min_height(state, reply_to),
 
             HostMsg::GetValue {
                 height,

diff --git a/code/examples/channel/src/app.rs b/code/examples/channel/src/app.rs
@@ -73,9 +73,9 @@ pub async fn run(
                     .await?;
             }
 
-            AppMsg::GetEarliestBlockHeight { reply } => {
+            AppMsg::GetHistoryMinHeight { reply } => {
                 if reply.send(state.get_earliest_height()).is_err() {
-                    error!("Failed to send GetEarliestBlockHeight reply");
+                    error!("Failed to send GetHistoryMinHeight reply");
                 }
             }