Remove Value::is_valid as proposal validity is now handled outside …

…of the state machine by the driver
informalsystems · Nov 7, 2023 · 45d4575 · 45d4575
1 parent d517da1
commit 45d4575
Show file tree

Hide file tree

Showing 3 changed files with 4 additions and 12 deletions.
diff --git a/Code/common/src/value.rs b/Code/common/src/value.rs
@@ -11,7 +11,4 @@ where
 
     /// The ID of the value.
     fn id(&self) -> Self::Id;
-
-    /// Whether the value is valid.
-    fn is_valid(&self) -> bool;
 }
diff --git a/Code/round/src/state_machine.rs b/Code/round/src/state_machine.rs
@@ -71,11 +71,10 @@ where
             if this_round && proposal.pol_round().is_nil() =>
         {
             // L22
-            if proposal.value().is_valid()
-                && state
-                    .locked
-                    .as_ref()
-                    .map_or(true, |locked| &locked.value == proposal.value())
+            if state
+                .locked
+                .as_ref()
+                .map_or(true, |locked| &locked.value == proposal.value())
             {
                 state.proposal = Some(proposal.clone());
                 prevote(state, data.address, &proposal)

diff --git a/Code/test/src/value.rs b/Code/test/src/value.rs
@@ -42,10 +42,6 @@ impl Value {
 impl malachite_common::Value for Value {
     type Id = ValueId;
 
-    fn is_valid(&self) -> bool {
-        self.valid()
-    }
-
     fn id(&self) -> ValueId {
         self.id()
     }