test(mbt): MBT for round state machine #452
Annotations
11 errors and 7 warnings
Formatting
Process completed with exit code 1.
|
Clippy:
itf/tests/consensus/runner.rs#L175
error: unneeded unit expression
--> itf/tests/consensus/runner.rs:175:21
|
175 | ()
| ^^ help: remove the final `()`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit
= note: `-D clippy::unused-unit` implied by `-D warnings`
= help: to override `-D warnings` add `#[allow(clippy::unused_unit)]`
|
Clippy:
itf/tests/consensus/runner.rs#L28
error: casting to the same type is unnecessary (`i64` -> `i64`)
--> itf/tests/consensus/runner.rs:28:21
|
28 | let round = expected.state.round as i64;
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `expected.state.round`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast
= note: `-D clippy::unnecessary-cast` implied by `-D warnings`
= help: to override `-D warnings` add `#[allow(clippy::unnecessary_cast)]`
|
Clippy:
itf/tests/consensus/runner.rs#L47
error: casting to the same type is unnecessary (`i64` -> `i64`)
--> itf/tests/consensus/runner.rs:47:46
|
47 | let input_round = Round::new(*round as i64);
| ^^^^^^^^^^^^^ help: try: `*round`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast
|
Clippy:
itf/tests/consensus/runner.rs#L52
error: casting to the same type is unnecessary (`i64` -> `i64`)
--> itf/tests/consensus/runner.rs:52:46
|
52 | let input_round = Round::new(*round as i64);
| ^^^^^^^^^^^^^ help: try: `*round`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast
|
Clippy:
itf/tests/consensus/runner.rs#L56
error: casting to the same type is unnecessary (`i64` -> `i64`)
--> itf/tests/consensus/runner.rs:56:46
|
56 | let input_round = Round::new(*round as i64);
| ^^^^^^^^^^^^^ help: try: `*round`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast
|
Clippy:
itf/tests/consensus/runner.rs#L61
error: this expression creates a reference which is immediately dereferenced by the compiler
--> itf/tests/consensus/runner.rs:61:38
|
61 | value_from_model(&value).unwrap(),
| ^^^^^^ help: change this to: `value`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow
= note: `-D clippy::needless-borrow` implied by `-D warnings`
= help: to override `-D warnings` add `#[allow(clippy::needless_borrow)]`
|
Clippy:
itf/tests/consensus/runner.rs#L67
error: casting to the same type is unnecessary (`i64` -> `i64`)
--> itf/tests/consensus/runner.rs:67:46
|
67 | let input_round = Round::new(*valid_round as i64);
| ^^^^^^^^^^^^^^^^^^^ help: try: `*valid_round`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast
|
Clippy:
itf/tests/consensus/runner.rs#L72
error: this expression creates a reference which is immediately dereferenced by the compiler
--> itf/tests/consensus/runner.rs:72:38
|
72 | value_from_model(&value).unwrap(),
| ^^^^^^ help: change this to: `value`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow
|
Clippy:
itf/tests/consensus/runner.rs#L82
error: this expression creates a reference which is immediately dereferenced by the compiler
--> itf/tests/consensus/runner.rs:82:38
|
82 | value_from_model(&value).unwrap(),
| ^^^^^^ help: change this to: `value`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow
|
Clippy:
itf/tests/consensus/runner.rs#L93
error: this expression creates a reference which is immediately dereferenced by the compiler
--> itf/tests/consensus/runner.rs:93:38
|
93 | value_from_model(&value).unwrap(),
| ^^^^^^ help: change this to: `value`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow
|
Formatting:
Code/itf/src/types.rs#L108
Diff in /home/runner/work/malachite/malachite/Code/itf/src/types.rs
|
Formatting:
Code/itf/tests/consensus/runner.rs#L45
Diff in /home/runner/work/malachite/malachite/Code/itf/tests/consensus/runner.rs
|
Formatting:
Code/itf/tests/consensus/runner.rs#L96
Diff in /home/runner/work/malachite/malachite/Code/itf/tests/consensus/runner.rs
|
Formatting:
Code/itf/tests/consensus/runner.rs#L111
Diff in /home/runner/work/malachite/malachite/Code/itf/tests/consensus/runner.rs
|
Formatting:
Code/itf/tests/consensus/runner.rs#L115
Diff in /home/runner/work/malachite/malachite/Code/itf/tests/consensus/runner.rs
|
Formatting:
Code/itf/tests/consensus/runner.rs#L119
Diff in /home/runner/work/malachite/malachite/Code/itf/tests/consensus/runner.rs
|
Clippy
The following actions uses node12 which is deprecated and will be forced to run on node16: actions-rs/clippy@master. For more info: https://github.blog/changelog/2023-06-13-github-actions-all-actions-will-run-on-node16-instead-of-node12-by-default/
|