test(mbt): MBT for round state machine #451
Annotations
13 errors and 2 warnings
Formatting
Process completed with exit code 1.
|
Clippy:
itf/tests/consensus/runner.rs#L227
error: unneeded unit expression
--> itf/tests/consensus/runner.rs:227:21
|
227 | ()
| ^^ help: remove the final `()`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit
= note: `-D clippy::unused-unit` implied by `-D warnings`
= help: to override `-D warnings` add `#[allow(clippy::unused_unit)]`
|
Clippy:
itf/tests/consensus/runner.rs#L69
error: unused variable: `value`
--> itf/tests/consensus/runner.rs:69:49
|
69 | ModelInput::NewRoundProposer(round, value) => {
| ^^^^^ help: if this is intentional, prefix it with an underscore: `_value`
|
= note: `-D unused-variables` implied by `-D warnings`
= help: to override `-D warnings` add `#[allow(unused_variables)]`
|
Clippy:
itf/tests/consensus/runner.rs#L32
error: casting to the same type is unnecessary (`i64` -> `i64`)
--> itf/tests/consensus/runner.rs:32:29
|
32 | let round = state.round as i64;
| ^^^^^^^^^^^^^^^^^^ help: try: `state.round`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast
= note: `-D clippy::unnecessary-cast` implied by `-D warnings`
= help: to override `-D warnings` add `#[allow(clippy::unnecessary_cast)]`
|
Clippy:
itf/tests/consensus/runner.rs#L63
error: casting to the same type is unnecessary (`i64` -> `i64`)
--> itf/tests/consensus/runner.rs:63:46
|
63 | let input_round = Round::new(*round as i64);
| ^^^^^^^^^^^^^ help: try: `*round`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast
|
Clippy:
itf/tests/consensus/runner.rs#L71
error: casting to the same type is unnecessary (`i64` -> `i64`)
--> itf/tests/consensus/runner.rs:71:46
|
71 | let input_round = Round::new(*round as i64);
| ^^^^^^^^^^^^^ help: try: `*round`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast
|
Clippy:
itf/tests/consensus/runner.rs#L78
error: casting to the same type is unnecessary (`i64` -> `i64`)
--> itf/tests/consensus/runner.rs:78:46
|
78 | let input_round = Round::new(*round as i64);
| ^^^^^^^^^^^^^ help: try: `*round`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast
|
Clippy:
itf/tests/consensus/runner.rs#L83
error: this expression creates a reference which is immediately dereferenced by the compiler
--> itf/tests/consensus/runner.rs:83:38
|
83 | value_from_model(&value).unwrap(),
| ^^^^^^ help: change this to: `value`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow
= note: `-D clippy::needless-borrow` implied by `-D warnings`
= help: to override `-D warnings` add `#[allow(clippy::needless_borrow)]`
|
Clippy:
itf/tests/consensus/runner.rs#L91
error: casting to the same type is unnecessary (`i64` -> `i64`)
--> itf/tests/consensus/runner.rs:91:46
|
91 | let input_round = Round::new(*valid_round as i64);
| ^^^^^^^^^^^^^^^^^^^ help: try: `*valid_round`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast
|
Clippy:
itf/tests/consensus/runner.rs#L96
error: this expression creates a reference which is immediately dereferenced by the compiler
--> itf/tests/consensus/runner.rs:96:38
|
96 | value_from_model(&value).unwrap(),
| ^^^^^^ help: change this to: `value`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow
|
Clippy:
itf/tests/consensus/runner.rs#L108
error: this expression creates a reference which is immediately dereferenced by the compiler
--> itf/tests/consensus/runner.rs:108:38
|
108 | value_from_model(&value).unwrap(),
| ^^^^^^ help: change this to: `value`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow
|
Test
unused variable: `value`
|
Test
Process completed with exit code 101.
|
Formatting:
Code/itf/tests/consensus/runner.rs#L66
Diff in /home/runner/work/malachite/malachite/Code/itf/tests/consensus/runner.rs
|
Clippy
The following actions uses node12 which is deprecated and will be forced to run on node16: actions-rs/clippy@master. For more info: https://github.blog/changelog/2023-06-13-github-actions-all-actions-will-run-on-node16-instead-of-node12-by-default/
|