fix(votekeeper): Compute threshold directly in VoteKeeper
to account for Skip
threshold
#244
Annotations
20 errors and 1 warning
Clippy:
test/tests/driver.rs#L1140
error[E0061]: this function takes 5 arguments but 6 arguments were supplied
--> test/tests/driver.rs:1140:22
|
1140 | let mut driver = Driver::new(ctx, env, sel, Height::new(1), vs, my_addr);
| ^^^^^^^^^^^ ----------------
| | |
| | unexpected argument of type `malachite_test::Height`
| help: remove the extra argument
|
note: associated function defined here
--> /home/runner/work/malachite/malachite/Code/driver/src/driver.rs:47:12
|
47 | pub fn new(
| ^^^
|
Clippy:
test/tests/driver.rs#L1146
error[E0061]: this enum variant takes 2 arguments but 1 argument was supplied
--> test/tests/driver.rs:1146:31
|
1146 | input_event: Some(Event::NewRound(Round::new(0))),
| ^^^^^^^^^^^^^^^--------------- an argument of type `malachite_common::Round` is missing
|
note: tuple variant defined here
--> /home/runner/work/malachite/malachite/Code/driver/src/event.rs:11:5
|
11 | NewRound(Ctx::Height, Round),
| ^^^^^^^^
help: provide the argument
|
1146 | input_event: Some(Event::NewRound(Round::new(0), /* malachite_common::Round */)),
| ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
|
Clippy:
test/tests/driver.rs#L1146
error[E0271]: type mismatch resolving `<TestContext as Context>::Height == Round`
--> test/tests/driver.rs:1146:31
|
1146 | input_event: Some(Event::NewRound(Round::new(0))),
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ expected `Height`, found `Round`
|
Clippy:
test/tests/driver.rs#L1149
error[E0063]: missing field `height` in initializer of `malachite_round::state::State<_>`
--> test/tests/driver.rs:1149:24
|
1149 | new_state: State {
| ^^^^^ missing `height`
|
Clippy:
test/tests/driver.rs#L1162
error[E0061]: this function takes 4 arguments but 3 arguments were supplied
--> test/tests/driver.rs:1162:17
|
1162 | Vote::new_prevote(Round::new(0), None, my_addr).signed(&my_sk),
| ^^^^^^^^^^^^^^^^^ ------------- an argument of type `malachite_test::Height` is missing
|
note: associated function defined here
--> /home/runner/work/malachite/malachite/Code/test/src/vote.rs:18:12
|
18 | pub fn new_prevote(
| ^^^^^^^^^^^
help: provide the argument
|
1162 | Vote::new_prevote(/* malachite_test::Height */, Round::new(0), None, my_addr).signed(&my_sk),
| ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
|
Clippy:
test/tests/driver.rs#L1165
error[E0063]: missing field `height` in initializer of `malachite_round::state::State<_>`
--> test/tests/driver.rs:1165:24
|
1165 | new_state: State {
| ^^^^^ missing `height`
|
Clippy:
test/tests/driver.rs#L1179
error[E0063]: missing field `height` in initializer of `malachite_round::state::State<_>`
--> test/tests/driver.rs:1179:24
|
1179 | new_state: State {
| ^^^^^ missing `height`
|
Clippy:
test/tests/driver.rs#L1191
error[E0061]: this function takes 4 arguments but 3 arguments were supplied
--> test/tests/driver.rs:1191:17
|
1191 | Vote::new_prevote(Round::new(1), Some(value.id()), addr1).signed(&sk1),
| ^^^^^^^^^^^^^^^^^ ------------- an argument of type `malachite_test::Height` is missing
|
note: associated function defined here
--> /home/runner/work/malachite/malachite/Code/test/src/vote.rs:18:12
|
18 | pub fn new_prevote(
| ^^^^^^^^^^^
help: provide the argument
|
1191 | Vote::new_prevote(/* malachite_test::Height */, Round::new(1), Some(value.id()), addr1).signed(&sk1),
| ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
|
Clippy:
test/tests/driver.rs#L1195
error[E0063]: missing field `height` in initializer of `malachite_round::state::State<_>`
--> test/tests/driver.rs:1195:24
|
1195 | new_state: State {
| ^^^^^ missing `height`
|
Clippy:
test/tests/driver.rs#L1207
error[E0061]: this function takes 4 arguments but 3 arguments were supplied
--> test/tests/driver.rs:1207:17
|
1207 | Vote::new_prevote(Round::new(1), Some(value.id()), addr2).signed(&sk2),
| ^^^^^^^^^^^^^^^^^ ------------- an argument of type `malachite_test::Height` is missing
|
note: associated function defined here
--> /home/runner/work/malachite/malachite/Code/test/src/vote.rs:18:12
|
18 | pub fn new_prevote(
| ^^^^^^^^^^^
help: provide the argument
|
1207 | Vote::new_prevote(/* malachite_test::Height */, Round::new(1), Some(value.id()), addr2).signed(&sk2),
| ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
|
Test
this function takes 5 arguments but 6 arguments were supplied
|
Test
this enum variant takes 2 arguments but 1 argument was supplied
|
Test
type mismatch resolving `<TestContext as Context>::Height == Round`
|
Test
missing field `height` in initializer of `State<_>`
|
Test
this function takes 4 arguments but 3 arguments were supplied
|
Test
missing field `height` in initializer of `State<_>`
|
Test
missing field `height` in initializer of `State<_>`
|
Test
this function takes 4 arguments but 3 arguments were supplied
|
Test
missing field `height` in initializer of `State<_>`
|
Test
this function takes 4 arguments but 3 arguments were supplied
|
Clippy
The following actions uses node12 which is deprecated and will be forced to run on node16: actions-rs/clippy@master. For more info: https://github.blog/changelog/2023-06-13-github-actions-all-actions-will-run-on-node16-instead-of-node12-by-default/
|