Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: support Svelte 5 in peer dependencies #60

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

shyakadavis
Copy link

First off, thank you for the lib - a favourite of mine.

Not sure if you plan to re-write the internals in Svelte 5, but as is, the lib just works. Only issue is the minor warning when installing in v5 projects.

Please let me know if I missed anything, or if there is an issue with this.

@indaco
Copy link
Owner

indaco commented Jan 8, 2025

Hi @shyakadavis
Thanks for your PR. I don't think there is any issue with it.

Will merge it as it is and create a new release over the weekend.

I'm not so sure about to reimplement it on Svelte 5 due to limited time on my side as well as for backward compatibility with at least v4.

If you are interested in doing it, your contribution is more than welcome.

Thanks again for your help

@shyakadavis
Copy link
Author

Without making any promises (because this would be my first time working on a lib), I'm interested in opening a migration P.R. I'll try my best to in the coming weeks. Let's hope there won't be any breaking changes.

@indaco
Copy link
Owner

indaco commented Jan 8, 2025

"You don’t have to migrate to the new syntax right away - Svelte 5 still supports the old Svelte 4 syntax, and you can mix and match components using the new syntax with components using the old and vice versa."

https://svelte.dev/docs/svelte/v5-migration-guide

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants