Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix script pre_translate.sh #334

Merged
merged 4 commits into from
Aug 22, 2016
Merged

Fix script pre_translate.sh #334

merged 4 commits into from
Aug 22, 2016

Conversation

adisadit
Copy link
Contributor

No description provided.

@adisadit
Copy link
Contributor Author

@timlinux hi Tim, could you check this PR? Like what you suggest in #332 i comment those line and tried to run the script again. And i didn't see any error. So, i assume this script work without those line.

@timlinux
Copy link
Contributor

Hi @adissadis

It would be better if in this PR you made a branch which included only the changes to the scripts and not all the other tr updates.

@adisadit
Copy link
Contributor Author

@timlinux do you mean i separate the scripts fix and tr update and push those branch into this PR?

@adisadit
Copy link
Contributor Author

adisadit commented Aug 1, 2016

@timlinux i already made a branch in my repo (pre_transifex_merge) but i don't know how to push this branch to this PR

@timlinux
Copy link
Contributor

timlinux commented Aug 8, 2016

@adissadis if you do (from your branch):

git push origin <branch name>

Then go to your GitHub fork on the web and make a pull request from there.

@adisadit
Copy link
Contributor Author

@timlinux okay i already do it in #335

so can i merge this Pull request?

@adisadit adisadit merged commit f5cb9ce into inasafe:develop Aug 22, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants