Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: added zk evm sign typed data method #146

Merged
merged 2 commits into from
Oct 25, 2024
Merged

feat: added zk evm sign typed data method #146

merged 2 commits into from
Oct 25, 2024

Conversation

YermekG
Copy link
Contributor

@YermekG YermekG commented Oct 24, 2024

Summary

Added ZkEvmSignTypedDataV4 method so users can sign EIP-712 structure messages using their Passport wallet.

  • Prefix your PR title with feat: , fix: , chore: , docs: , refactor: or test: .
  • Sample blueprints are updated with new SDK changes
  • Updated public documentation with new SDK changes (Immutable X and Immutable zkEVM)
  • Replied to GitHub issues

@YermekG YermekG requested a review from a team as a code owner October 24, 2024 09:44
@YermekG YermekG requested a review from nattb8 October 24, 2024 09:49
Copy link
Collaborator

@nattb8 nattb8 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we add this into the sample blueprints?

@YermekG
Copy link
Contributor Author

YermekG commented Oct 24, 2024

Can we add this into the sample blueprints?

Added the blueprint sample

@YermekG YermekG enabled auto-merge (squash) October 24, 2024 23:40
@YermekG YermekG merged commit 570d0a4 into main Oct 25, 2024
10 checks passed
@YermekG YermekG deleted the feat/signtypeddata branch October 25, 2024 01:27
ImmutableJeffrey pushed a commit that referenced this pull request Nov 26, 2024
* feat: added zk evm sign typed data method

* feat: added blueprint sample for sign typed data method
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Development

Successfully merging this pull request may close these issues.

2 participants