Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: minor improvements #140

Merged
merged 2 commits into from
Oct 8, 2024
Merged

feat: minor improvements #140

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
bc47382
fix: fixed minor issues
YermekG Oct 2, 2024
07e4868
fix: compile issues with header file inclusion
YermekG Oct 6, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion Source/Immutable/Private/Immutable/ImtblBlui.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -93,7 +93,11 @@ void UImtblBlui::Init()
BluEye->bEnabled = true;
IMTBL_LOG("Events subscribed")

BluEye->Init();
if (!BluEye->Init())
{
IMTBL_ERR("BluEye is not initialised")
return;
}
IMTBL_LOG("BluEye Initialised")

// We're attempting to replicate the process that Unreal's WebBrowser
Expand Down
4 changes: 2 additions & 2 deletions Source/Immutable/Public/Immutable/Actions/ImtblBlueprintAsyncAction.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@

#pragma once

#include "CoreMinimal.h"
#include "Immutable/ImmutableSubsystem.h"
#include "Kismet/BlueprintAsyncActionBase.h"

#include "ImtblBlueprintAsyncAction.generated.h"
Expand All @@ -20,5 +20,5 @@ class IMMUTABLE_API UImtblBlueprintAsyncAction : public UBlueprintAsyncActionBas
UObject* WorldContextObject;

// Get subsystem
class UImmutableSubsystem* GetSubsystem() const;
UImmutableSubsystem* GetSubsystem() const;
};
2 changes: 1 addition & 1 deletion Source/Immutable/Public/Immutable/ImmutableDataTypes.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -100,7 +100,7 @@ struct FImtblUserProfile
};

USTRUCT()
struct FImmutablePassportZkEvmRequestAccountsData
struct IMMUTABLE_API FImmutablePassportZkEvmRequestAccountsData
{
GENERATED_BODY()

Expand Down
6 changes: 3 additions & 3 deletions Source/Immutable/Public/Immutable/ImmutableSubsystem.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@

#pragma once

#include "CoreMinimal.h"
#include "ImmutablePassport.h"
#include "Subsystems/GameInstanceSubsystem.h"
// clang-format off
#include "ImmutableSubsystem.generated.h"
Expand All @@ -22,7 +22,7 @@ class IMMUTABLE_API UImmutableSubsystem : public UGameInstanceSubsystem
virtual void Initialize(FSubsystemCollectionBase& Collection) override;
virtual void Deinitialize() override;

TWeakObjectPtr<class UImmutablePassport> GetPassport() const
TWeakObjectPtr<UImmutablePassport> GetPassport() const
{
return MakeWeakObjectPtr(Passport);
}
Expand Down Expand Up @@ -56,7 +56,7 @@ class IMMUTABLE_API UImmutableSubsystem : public UGameInstanceSubsystem
class UImtblBlui* ImtblBlui = nullptr;

UPROPERTY()
class UImmutablePassport* Passport = nullptr;
UImmutablePassport* Passport = nullptr;

bool bHasSetupGameBridge = false;
bool bIsReady = false;
Expand Down
Loading