Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RM permissions block from main merge workflow and update PR template #18

Merged
merged 3 commits into from
Jan 7, 2025
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion .github/pull_request_template.md
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
# Summary

<!---
<!---
Provide a short summary of the changes and the reasoning behind them.

Include references to related issues (e.g. #1234 which will make a direct link to the issue).
Expand All @@ -16,3 +16,4 @@ Include @mentions to any relevant contributors and maintainers.
- [ ] Bugs fixed
- [ ] Unit tests added or updated
- [ ] E2E tests added or updated
- [ ] CI updated
21 changes: 0 additions & 21 deletions .github/workflows/main.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -6,10 +6,6 @@ on:
- main
workflow_dispatch:

permissions: # see this: https://docs.github.com/en/actions/using-jobs/assigning-permissions-to-jobs
id-token: write # This is required for requesting the JWT
contents: write # This is required for actions/checkout

jobs:
push:
name: Push Docker
Expand All @@ -20,20 +16,3 @@ jobs:
- uses: ./.github/actions/push
with:
github-token: ${{ secrets.GITHUB_TOKEN }}

tests:
name: Tests
runs-on: ubuntu-20-04-4-cores
timeout-minutes: 35
steps:
- uses: actions/checkout@v4
- uses: actions/setup-go@v3
with:
go-version: 1.20.x
- name: Cache modules
uses: ./.github/actions/cache/golang
- name: All Tests
shell: bash
run: |
go run build/ci.go install
go test $(go list ./... | grep -v 'go-ethereum/tests/immutable') -p 1 --parallel 4 -timeout=30m
2 changes: 0 additions & 2 deletions .github/workflows/pr.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -2,8 +2,6 @@ name: PR

on:
pull_request:
push:
branches: master

concurrency:
group: PR-${{ github.head_ref }}
Expand Down