Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(generator/client): Add more options support #45

Merged
merged 3 commits into from
Dec 2, 2023
Merged

feat(generator/client): Add more options support #45

merged 3 commits into from
Dec 2, 2023

Conversation

muink
Copy link
Collaborator

@muink muink commented Nov 16, 2023

  1. Add DNS global options
    • + dns.independent_cache
    • + dns.reverse_mapping
  2. Add System DNS server address: 'local' for resolving custom private domain
    • + dns.servers[1]
  3. DNS rules
    • - homeproxy.@dns_rule[-1].ip_cidr
    • + dns.rules.query_type
    • + dns.rules.ip_version
    • + dns.rules.auth_user
    • + dns.rules.user_id
    • + dns.rules.clash_mode
    • + dns.rules.rewrite_ttl
    • Allow dns.rules.outbound: 'any'
  4. Route rules
    • + route.rules.auth_user
    • + route.rules.user_id
    • + route.rules.clash_mode

@1715173329
Copy link
Member

  • f6d1748: feat(client): dns.servers: Add system DNS
  • 5765506: fix(client): dns.rules: Remove invalid option and update description
  • 8b9053b: chore(client): dns.rules: Move option sequence
  • af8aba0: feat(client): dns.rules: Allow outbound any

I've applied part of your changes, please rebase this PR then let's discuss the remaining ones.

@muink muink force-pushed the dev/options branch 2 times, most recently from 469d7cf to 2e57dfc Compare November 20, 2023 13:45
@muink
Copy link
Collaborator Author

muink commented Nov 20, 2023

I've rebased the branch and I think we can continue.

@muink
Copy link
Collaborator Author

muink commented Nov 27, 2023

Can we continue with the rest?

@1715173329
Copy link
Member

So sorry I'm super busy these days and the review has to be delayed.

1715173329
1715173329 requested changes Nov 30, 2023
View reviewed changes
htdocs/luci-static/resources/view/homeproxy/client.js Outdated Show resolved Hide resolved
htdocs/luci-static/resources/view/homeproxy/client.js Outdated Show resolved Hide resolved
htdocs/luci-static/resources/view/homeproxy/client.js Outdated Show resolved Hide resolved
htdocs/luci-static/resources/view/homeproxy/client.js Outdated Show resolved Hide resolved
htdocs/luci-static/resources/view/homeproxy/client.js Outdated Show resolved Hide resolved
htdocs/luci-static/resources/view/homeproxy/client.js Outdated Show resolved Hide resolved
htdocs/luci-static/resources/view/homeproxy/client.js Outdated Show resolved Hide resolved
htdocs/luci-static/resources/view/homeproxy/client.js Outdated Show resolved Hide resolved
@muink
Copy link
Collaborator Author

muink commented Dec 1, 2023

Redundant options have been cleaned up

@muink muink requested a review from 1715173329 December 1, 2023 11:50
muink
muink commented Dec 2, 2023
View reviewed changes
Copy link
Collaborator Author

@muink muink left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

@muink muink requested a review from 1715173329 December 2, 2023 08:39
@1715173329 1715173329 merged commit 13793bc into immortalwrt:dev Dec 2, 2023
1 check passed
@muink muink deleted the dev/options branch December 2, 2023 12:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@1715173329 1715173329 1715173329 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@muink @1715173329