Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add generic text and grammar revisions #24

Merged
merged 2 commits into from
Jul 8, 2018
Merged

Add generic text and grammar revisions #24

merged 2 commits into from
Jul 8, 2018

Conversation

srschramm
Copy link
Collaborator

Moving my minor textual changes from sharelatex to github.

@matthewfeickert
Copy link
Member

Thanks, @srschramm (that was quick 👍). This builds the draft that can be found here. After a quick scan this can get merged in right away to serve as the basis for the PR that @pseyfert and @SergeiML can write together for your Issue #23.

@srschramm
Copy link
Collaborator Author

Hi Matthew,

I just looked at the build draft and it looks fine and as expected from my side. I agree that this can be merged right away and serve as the basis for issue #23. That was indeed the intent - fix the trivial things, and let the more complex ones be debated.

Best regards,
Steven

@matthewfeickert matthewfeickert changed the title Textual fixes from Steven on July 8 WIP: Generic text revisions Jul 8, 2018
@matthewfeickert
Copy link
Member

@srschramm Actually, let me go in and fix the issues with the \clearpage now. I know you need to go to bed, but I'll get this and then let @pseyfert and @SergeiML do the other revisions.

@srschramm
Copy link
Collaborator Author

Great, thanks Matthew. Indeed, I'll head to bed now. Good luck to @pseyfert and @SergeiML for the other fixes! If you're happy with my proposed solutions it shouldn't take too much work (I hope)!

matthewfeickert
matthewfeickert reviewed Jul 8, 2018
View reviewed changes
src/collaboration.tex Outdated
@@ -30,7 +30,7 @@ \subsection{Academic Outreach and Engagement}
\clearpage
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This \clearpage was put in originally for page continuity, but now needs to get edited.

@matthewfeickert
Make figures and tables fit with text
dbc5da7 
Avoid cutting off single trailing lines of paragraphs from appearing
orphaned due to a table or figure appearing at the start or end of a
page.
This effectivley removes most uses of \clearpage in the document.
@matthewfeickert matthewfeickert changed the title WIP: Generic text revisions Add generic text and grammar revisions Jul 8, 2018
@matthewfeickert matthewfeickert merged commit e02f272 into master Jul 8, 2018
@matthewfeickert matthewfeickert deleted the revise/sschramm-revisions branch July 8, 2018 14:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@matthewfeickert matthewfeickert matthewfeickert left review comments

@pseyfert pseyfert Awaiting requested review from pseyfert

@SergeiML SergeiML Awaiting requested review from SergeiML

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@srschramm @matthewfeickert