Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove redundant 'sync' when closing Netty connection #2637

Merged
merged 1 commit into from
Dec 18, 2024
Merged

Remove redundant 'sync' when closing Netty connection #2637

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions xmppserver/src/main/java/org/jivesoftware/openfire/nio/NettyConnection.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -237,8 +237,7 @@ public void close(@Nullable final StreamError error, final boolean networkInterr
latch.countDown();
}
})
.addListener(e -> Log.trace("Finished closing connection."))
.sync(); // TODO: OF-2811 Remove this blocking operation (which may have been made redundant by the fix for OF-2808 anyway).
.addListener(e -> Log.trace("Finished closing connection."));
} catch (Throwable t) {
Log.error("Problem during connection close or cleanup", t);
latch.countDown(); // Ensure we're not kept waiting! OF-2845
Expand Down
Loading