Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minor optimizations on MooseVariableData #29697

Draft
wants to merge 2 commits into
base: next
Choose a base branch
from

Conversation

GiudGiud
Copy link
Contributor

locally I observed 8% speedup on simple_diffusion.i with -r 7.
I am hoping someone can reproduce so we can merge this.
I doubt the test suite will show a consistent improvement but let's see with this PR's run

@GiudGiud GiudGiud self-assigned this Jan 17, 2025
@moosebuild
Copy link
Contributor

Job Documentation, step Docs: sync website on 94117f9 wanted to post the following:

View the site here

This comment will be updated on new commits.

@moosebuild
Copy link
Contributor

Job Coverage, step Generate coverage on 94117f9 wanted to post the following:

Framework coverage

b45164 #29697 94117f
Total Total +/- New
Rate 85.25% 85.23% -0.02% 65.58%
Hits 108039 108022 -17 101
Misses 18699 18726 +27 53

Diff coverage report

Full coverage report

Modules coverage

Coverage did not change

Full coverage reports

Reports

Warnings

  • framework new line coverage rate 65.58% is less than the suggested 90.0%

This comment will be updated on new commits.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants