Revert "Fix find_moose_executable utility" #29638
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dschwen
reviewed
Jan 3, 2025
dschwen
approved these changes
Jan 3, 2025
|
Merging without testing as this is a revert. Tests with the current base of this PR passed in https://civet.inl.gov/event/211556/. |
|
Okay, I (re)added the change to #29624. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reverts #29589
@nmnobre we messed up on this one.
scripts/versioner.yaml(see here) defines the dependencies for each of our released packages. You modified a file here that modifies themoose-devpackage without bumping the version formoose-dev. Whoops.We actually can't get this in right now because version bumps are currently unsupported due to some changes in conda.
@milljm let's add this commit to #29104.