Android Oreo Issues Has Been Resolved. #30
Conversation
Process Phoenix Has Been Added for restarting Application work better then refresh method....
|
Hello @zeeshanrasool91, and thanks for the contribution. Is this ready for review now? |
|
yes it is ready for review |
|
|
||
| @Override | ||
| protected void onCreate(Bundle savedInstanceState) { | ||
| super.onCreate(savedInstanceState); |
There was a problem hiding this comment.
No need for this method if it doesn't contain changes.
There was a problem hiding this comment.
@zeeshanrasool91 Any updates ion this?
| @@ -1,7 +1,11 @@ | |||
| package com.ahmedjazzar.rosetta.app; | |||
|
|
|||
| import android.app.Application; | |||
| import android.content.Context; | |||
There was a problem hiding this comment.
@zeeshanrasool91 Any updates on these?
| @@ -4,6 +4,6 @@ | |||
| <item name="windowActionBar">false</item> | |||
| <item name="windowNoTitle">true</item> | |||
| <item name="android:windowDrawsSystemBarBackgrounds">true</item> | |||
| <item name="android:statusBarColor">@android:color/transparent</item> | |||
| <item name="android:statusBarColor">@color/colorPrimaryDark</item> | |||
There was a problem hiding this comment.
it was actually showing me transparent view on my Lollipop device.
| @@ -15,6 +16,7 @@ buildscript { | |||
| allprojects { | |||
| repositories { | |||
| jcenter() | |||
| google() | |||
There was a problem hiding this comment.
it is required by Latest Compat Libraries
| @@ -153,7 +153,8 @@ protected void onPositiveClick() { | |||
| getActivity(), mSelectedLanguage)) { | |||
|
|
|||
| mLogger.info("App locale changed successfully."); | |||
| LocalesUtils.refreshApplication(getActivity()); | |||
| //LocalesUtils.refreshApplication(getActivity()); | |||
There was a problem hiding this comment.
when i was using your refresh method the problem was that it was recreating application and current activity both.
i just wanted to recreate whole application. so it can recreate all resources in my application
There was a problem hiding this comment.
Cool with me, but just no need to comment, removing the line is enough.
| @@ -265,7 +265,8 @@ static boolean setLocale(Locale newLocale, Activity activity) { | |||
| } | |||
|
|
|||
| if (LocalesUtils.setAppLocale(activity.getApplicationContext(), newLocale)) { | |||
| LocalesUtils.refreshApplication(activity); | |||
| //LocalesUtils.refreshApplication(activity); | |||
There was a problem hiding this comment.
when i was using your refresh method the problem was that it was recreating application and current activity both.
i just wanted to recreate whole application. so it can recreate all resources in my application
There was a problem hiding this comment.
Cool with me, but just no need to comment, removing the line is enough.
| @@ -0,0 +1,131 @@ | |||
| /* | |||
There was a problem hiding this comment.
Can't we just include it instead of copying and pasting it?
There was a problem hiding this comment.
i did it but was Creating problems that's why added it as a file, i tried to solve it once i will check then will commit this code.
There was a problem hiding this comment.
i did it so buddy. i added it as Dependency but for that i have to Add
in my Manifest in Main Default launcher Activity, other wise was causing crash.
|
Process Pheonix was Creating Issue when we included just because of Some
intent filters
…On Fri, Jun 29, 2018 at 5:14 PM Ahmed Jazzar ***@***.***> wrote:
***@***.**** requested changes on this pull request.
------------------------------
In app/src/main/java/com/ahmedjazzar/rosetta/app/MainApplication.java
<#30 (comment)>:
> @@ -1,7 +1,11 @@
package com.ahmedjazzar.rosetta.app;
import android.app.Application;
+import android.content.Context;
Why all these unused imports?
------------------------------
In app/src/main/res/values-v21/styles.xml
<#30 (comment)>:
> @@ -4,6 +4,6 @@
<item name="windowActionBar">false</item>
<item name="windowNoTitle">true</item>
<item name="android:windowDrawsSystemBarBackgrounds">true</item>
- <item ***@***.***:color/transparent</item>
+ <item ***@***.***/colorPrimaryDark</item>
Is this change necessary?
------------------------------
In build.gradle
<#30 (comment)>:
> @@ -15,6 +16,7 @@ buildscript {
allprojects {
repositories {
jcenter()
+ google()
Are we using this repository?
------------------------------
In
rosetta/src/main/java/com/ahmedjazzar/rosetta/LanguagesListDialogFragment.java
<#30 (comment)>:
> @@ -153,7 +153,8 @@ protected void onPositiveClick() {
getActivity(), mSelectedLanguage)) {
mLogger.info("App locale changed successfully.");
- LocalesUtils.refreshApplication(getActivity());
+ //LocalesUtils.refreshApplication(getActivity());
Just remove it
------------------------------
In rosetta/src/main/java/com/ahmedjazzar/rosetta/LocalesUtils.java
<#30 (comment)>:
> @@ -265,7 +265,8 @@ static boolean setLocale(Locale newLocale, Activity activity) {
}
if (LocalesUtils.setAppLocale(activity.getApplicationContext(), newLocale)) {
- LocalesUtils.refreshApplication(activity);
+ //LocalesUtils.refreshApplication(activity);
Just remove it.
------------------------------
In rosetta/src/main/java/com/ahmedjazzar/rosetta/ProcessPhoenix.java
<#30 (comment)>:
> @@ -0,0 +1,131 @@
+/*
Can't we just include it instead of copying and pasting it?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#30 (review)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AHFTed1n9CtmLgq7GP1mxwYfXVSSbVY9ks5uBhpDgaJpZM4UyAYl>
.
--
Regards:
Zeeshan Rasool
|
|
@AhmedAljazzar now you can Check and tell me |
| @@ -1,7 +1,11 @@ | |||
| package com.ahmedjazzar.rosetta.app; | |||
|
|
|||
| import android.app.Application; | |||
| import android.content.Context; | |||
There was a problem hiding this comment.
@zeeshanrasool91 Any updates on these?
|
|
||
| @Override | ||
| protected void onCreate(Bundle savedInstanceState) { | ||
| super.onCreate(savedInstanceState); |
There was a problem hiding this comment.
@zeeshanrasool91 Any updates ion this?
| //apply from: 'https://raw.githubusercontent.com/nuuneoi/JCenter/master/installv1.gradle' |
There was a problem hiding this comment.
No need to comment, just remove the line.
| //apply from: 'https://raw.githubusercontent.com/nuuneoi/JCenter/master/installv1.gradle' | ||
| //apply from: 'https://raw.githubusercontent.com/nuuneoi/JCenter/master/bintrayv1.gradle' |
There was a problem hiding this comment.
No need to comment as well, just remove the line.
| @@ -153,7 +153,8 @@ protected void onPositiveClick() { | |||
| getActivity(), mSelectedLanguage)) { | |||
|
|
|||
| mLogger.info("App locale changed successfully."); | |||
| LocalesUtils.refreshApplication(getActivity()); | |||
| //LocalesUtils.refreshApplication(getActivity()); | |||
There was a problem hiding this comment.
Cool with me, but just no need to comment, removing the line is enough.
| @@ -265,7 +265,8 @@ static boolean setLocale(Locale newLocale, Activity activity) { | |||
| } | |||
|
|
|||
| if (LocalesUtils.setAppLocale(activity.getApplicationContext(), newLocale)) { | |||
| LocalesUtils.refreshApplication(activity); | |||
| //LocalesUtils.refreshApplication(activity); | |||
There was a problem hiding this comment.
Cool with me, but just no need to comment, removing the line is enough.
Process Phoenix Has Been Added for restarting Application work better then refresh method....