Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add annotation dataclasses to pkg_types.py #112

Merged
merged 1 commit into from
Feb 21, 2024

Conversation

NoB0
Copy link
Collaborator

@NoB0 NoB0 commented Feb 20, 2024

Delete annotation.py and move its content to pkg_types.py.

Fixes #106

@NoB0 NoB0 requested a review from WerLaj as a code owner February 20, 2024 11:09
Copy link

Unit Test Results

58 tests   58 ✔️  6s ⏱️
  1 suites    0 💤
  1 files      0

Results for commit 11b75b4.

Copy link

Coverage Report •
FileStmtsMissCoverMissing
pkg_api
   pkg.py1201585%73, 84, 106–116, 132, 201, 268–269, 277–>274, 310–313, 347–348
   utils.py76295%163–>175, 168, 226
pkg_api/core
   pkg_types.py43196%57
pkg_api/nl_to_pkg
   eval_nl_to_pkg.py631081%105, 134–>156, 135–>142, 142–>149, 149–>156, 161–187
   nl_to_pkg.py120100% 
pkg_api/nl_to_pkg/annotators
   annotator.py11282%19, 34
   three_step_annotator.py50292%94–>exit, 97, 123
pkg_api/nl_to_pkg/entity_linking
   entity_linker.py6183%24
   rel_entity_linking.py32385%36, 40–>38, 60, 92
   spotlight_entity_linker.py33385%36, 40–>38, 60, 92
tests/nl_to_pkg
   test_eval_nl_to_pkg.py340100% 
   test_nl_to_pkg.py480100% 
   test_rel_entity_linker.py420100% 
   test_spotlight_entity_linker.py430100% 
   test_three_step_annotator.py620100% 
tests/pkg_api
   test_pkg.py420100% 
   test_utils.py480100% 
TOTAL11684994% 

Copy link

Current Branch Main Branch
Coverage Badge Coverage Badge

@NoB0 NoB0 requested a review from kbalog February 20, 2024 11:10
Copy link
Contributor

@kbalog kbalog left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Collaborator

@WerLaj WerLaj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@NoB0 NoB0 merged commit 958c423 into main Feb 21, 2024
5 checks passed
@NoB0 NoB0 deleted the feature/106-Rename-annotationpy branch February 21, 2024 15:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Rename annotation.py
3 participants