Fixed single quote escape and bigint issues #23
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: yxia2 <yxia2@ufl.edu>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fix addresses two issues we have in our system when using the latest code.
For label that contains single quote, its generated SQL doesn't escape well. As current escape only replace
'into\', while in sql, we need to replace'into''. The change in SqlClauseUtil.java is trying to avoid regression issue that might caused by changing directly onJDBCUtil.escapeSingleQuote(), as escapeSingleQuote are used by many other logics.For
ENCOUNTER_NUM int, we have an update to usebigint, we've discussion on https://groups.google.com/g/i2b2-install-help/c/ilylQPEseR4, and our in-house build, deploy, running works well, but not see the corresponding updates in the latest i2b2-core-server code. Therefore, this PR add the update.