-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor directory structure #15
base: main
Are you sure you want to change the base?
Conversation
@akihikokuroda is this still WIP? |
It's ready for review and comments. I'll take out WIP, Thanks! |
Great, thanks. Could you rebase to main? I've just updated the core dependencies across the project. |
fb4c0f9
to
9be984b
Compare
Thanks. Could you also go through the PR check list and tick off the items you're able to. |
9be984b
to
0635d92
Compare
E2e tests work except tests that require API key. |
No probs, I'll check those out as part of my review - many thanks for your contribution! |
This PR looks a bit muddled to me as it stands right now. I would recommend the following changes: Re-instate Global Examples Re-instate a default agent Don't exclude tests Locate all tests under the tests subdir Dont use @ imports |
0635d92
to
13891f0
Compare
Signed-off-by: Akihiko Kuroda <akihikokuroda2020@gmail.com>
13891f0
to
ec2707a
Compare
@grahamwhiteuk Thanks for review. I believe that all comments have been addressed. |
Which issue(s) does this pull-request address?
#14 This is the first proposal.
Closes: #14
Description
Restructure directories to contain most of changes in one tool under one directory
Checklist
yarn lint
oryarn lint:fix
yarn format
oryarn format:fix
yarn test:unit
yarn test:e2e