Remove --Xsnapsync-bft-enabled #1739
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Bhanu Pulluri <bhanu.pulluri@kaleido.io>
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
There was a problem hiding this comment.
Thanks for the contribution! Since this option only applies to private networks (IBFT 2.0 and QBFT networks), can you move this documentation to the private networks command line options reference page?
Signed-off-by: Bhanu Pulluri <bhanu.pulluri@kaleido.io>
macfarla
reviewed
Nov 27, 2024
|
ok per comments on the besu PR this option is being removed altogether |
macfarla
requested changes
Nov 28, 2024
…future release Signed-off-by: Bhanu Pulluri <bhanu.pulluri@kaleido.io>
pullurib
changed the title
Signed-off-by: Bhanu Pulluri <bhanu.pulluri@kaleido.io>
Signed-off-by: Bhanu Pulluri <bhanu.pulluri@kaleido.io>
Signed-off-by: Bhanu Pulluri <bhanu.pulluri@kaleido.io>
macfarla
reviewed
Dec 3, 2024
Signed-off-by: Alexandra Tran <alexandra.tran@consensys.net>
alexandratran
approved these changes
Dec 3, 2024
alexandratran
changed the title
macfarla
approved these changes
Dec 3, 2024
There was a problem hiding this comment.
LGTM but might be good to wait until hyperledger/besu#7930 is merged - right now you do still need to use --Xsnap-bft-enabled if you want to use SNAP on BFT networks (then again, anyone who needs to use that flag prob already knows about it)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Issue(s) fixed
#7924
Fixes #