Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Limit Trie Logs Early Access Feature Guide #1538

Merged
merged 20 commits into from
Mar 19, 2024
Merged

Add Limit Trie Logs Early Access Feature Guide #1538

merged 20 commits into from
Mar 19, 2024

Conversation

joaniefromtheblock
Copy link
Contributor

@joaniefromtheblock joaniefromtheblock commented Mar 12, 2024 •
edited
Loading

@vercel Vercel
Copy link

vercel bot commented Mar 12, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
besu-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Mar 19, 2024 3:06pm

@joaniefromtheblock
Merge branch 'main' into bonsai-tries-reduce
0b1cb6a 
Signed-off-by: Joan E <153745173+joaniefromtheblock@users.noreply.github.com>
@joaniefromtheblock joaniefromtheblock marked this pull request as ready for review March 12, 2024 18:15
@joaniefromtheblock joaniefromtheblock requested a review from a team as a code owner March 12, 2024 18:15
@joaniefromtheblock joaniefromtheblock mentioned this pull request Mar 12, 2024
Closed
@non-fungible-nelson
Copy link
Contributor

LGTM - let's ship and re-evaluate in an upcoming release of Besu.

siladu
siladu requested changes Mar 13, 2024
View reviewed changes
Copy link
Contributor

@siladu siladu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a few more tweaks

docs/public-networks/how-to/bonsai-limit-trie-logs.md Outdated Show resolved Hide resolved
docs/public-networks/how-to/bonsai-limit-trie-logs.md Outdated Show resolved Hide resolved
docs/public-networks/how-to/bonsai-limit-trie-logs.md Outdated Show resolved Hide resolved
docs/public-networks/how-to/bonsai-limit-trie-logs.md Outdated Show resolved Hide resolved
docs/public-networks/how-to/bonsai-limit-trie-logs.md Outdated Show resolved Hide resolved
docs/public-networks/how-to/bonsai-limit-trie-logs.md Outdated Show resolved Hide resolved
docs/public-networks/how-to/bonsai-limit-trie-logs.md Outdated Show resolved Hide resolved
docs/public-networks/how-to/bonsai-limit-trie-logs.md Outdated Show resolved Hide resolved
docs/public-networks/how-to/bonsai-limit-trie-logs.md Outdated Show resolved Hide resolved
docs/public-networks/how-to/bonsai-limit-trie-logs.md Outdated Show resolved Hide resolved
@joaniefromtheblock
apply Eng review suggestions
e7907e3 
Signed-off-by: Joan E <153745173+joaniefromtheblock@users.noreply.github.com>
@joaniefromtheblock joaniefromtheblock self-assigned this Mar 14, 2024
@joaniefromtheblock
Add admonition
bb3de9c 
Signed-off-by: Joan E <153745173+joaniefromtheblock@users.noreply.github.com>
@joaniefromtheblock
Add trie logs words to list
2e36b03 
Signed-off-by: Joan E <153745173+joaniefromtheblock@users.noreply.github.com>
@joaniefromtheblock
Merge branch 'main' into bonsai-tries-reduce
9afb2c5
@joaniefromtheblock
fix broken link
91e9290 
Signed-off-by: Joan E <153745173+joaniefromtheblock@users.noreply.github.com>
@joaniefromtheblock
Merge branch 'main' into bonsai-tries-reduce
f902a7c
@joaniefromtheblock
update formatting
2de878d 
Signed-off-by: Joan E <153745173+joaniefromtheblock@users.noreply.github.com>
siladu
siladu approved these changes Mar 18, 2024
View reviewed changes
Copy link
Contributor

@siladu siladu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Couple more minor comments, but think it's close enough - thanks! 👍

joaniefromtheblock and others added 2 commits March 18, 2024 17:15
@joaniefromtheblock
cleanup
9ebded7 
Signed-off-by: Joan E <153745173+joaniefromtheblock@users.noreply.github.com>
@joaniefromtheblock @siladu
change wording
38fd153 
Co-authored-by: Simon Dudley <simon.dudley@consensys.net>
Signed-off-by: Joan E <153745173+joaniefromtheblock@users.noreply.github.com>
@alexandratran alexandratran self-assigned this Mar 19, 2024
@joaniefromtheblock
change format
7232c31 
Signed-off-by: Joan E <153745173+joaniefromtheblock@users.noreply.github.com>
@joaniefromtheblock
fix spacing
9d10489 
Signed-off-by: Joan E <153745173+joaniefromtheblock@users.noreply.github.com>
bgravenorst
bgravenorst approved these changes Mar 19, 2024
View reviewed changes
Copy link
Contributor

@bgravenorst bgravenorst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

alexandratran
alexandratran approved these changes Mar 19, 2024
View reviewed changes
Copy link
Contributor

@alexandratran alexandratran left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can merge after committing suggestions, since this is short-lived content. For future reference, also make sample commands more readable by adding line breaks (for example: https://besu.hyperledger.org/public-networks/tutorials/besu-teku-mainnet#beacon-node-only

docs/public-networks/how-to/bonsai-limit-trie-logs.md Outdated Show resolved Hide resolved
docs/public-networks/how-to/bonsai-limit-trie-logs.md Show resolved Hide resolved
docs/public-networks/how-to/bonsai-limit-trie-logs.md Outdated Show resolved Hide resolved
docs/public-networks/how-to/bonsai-limit-trie-logs.md Outdated Show resolved Hide resolved
docs/public-networks/how-to/bonsai-limit-trie-logs.md Show resolved Hide resolved
docs/public-networks/how-to/bonsai-limit-trie-logs.md Outdated Show resolved Hide resolved
docs/public-networks/how-to/bonsai-limit-trie-logs.md Outdated Show resolved Hide resolved
docs/public-networks/how-to/bonsai-limit-trie-logs.md Outdated Show resolved Hide resolved
docs/public-networks/how-to/bonsai-limit-trie-logs.md Outdated Show resolved Hide resolved
docs/public-networks/how-to/bonsai-limit-trie-logs.md Outdated Show resolved Hide resolved
joaniefromtheblock
joaniefromtheblock commented Mar 19, 2024
View reviewed changes
Copy link
Contributor Author

@joaniefromtheblock joaniefromtheblock left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@alexandratran is Mainnet always capitalized, or just in this case? Looking at instances of it, it seems that it is stylized as "mainnet" for general cases. Is it a proper noun in this, because we are referring to the Ethereum Mainnet?

joaniefromtheblock
joaniefromtheblock commented Mar 19, 2024
View reviewed changes
Copy link
Contributor Author

@joaniefromtheblock joaniefromtheblock left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

.

@joaniefromtheblock @alexandratran
Apply suggestions from code review
1b7faa7 
Co-authored-by: Alexandra Tran Carrillo <12214231+alexandratran@users.noreply.github.com>
Signed-off-by: Joan E <153745173+joaniefromtheblock@users.noreply.github.com>
@joaniefromtheblock @alexandratran
Apply suggestions from code review
e1c95c8 
Co-authored-by: Alexandra Tran Carrillo <12214231+alexandratran@users.noreply.github.com>
Signed-off-by: Joan E <153745173+joaniefromtheblock@users.noreply.github.com>
@joaniefromtheblock
change heading
e641fd3 
Signed-off-by: Joan E <153745173+joaniefromtheblock@users.noreply.github.com>
@alexandratran
Copy link
Contributor

@joaniefromtheblock We use capital "Mainnet" whenever we refer to it throughout the Besu docs and most of our other docs. We can discuss updating this in the future, but for consistency we should stick to one style throughout the docs. Where do you see instances of lowercase "mainnet" in our docs?

@joaniefromtheblock joaniefromtheblock merged commit 1b43f77 into hyperledger:main Mar 19, 2024
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@non-fungible-nelson non-fungible-nelson non-fungible-nelson approved these changes

@bgravenorst bgravenorst bgravenorst approved these changes

@alexandratran alexandratran alexandratran approved these changes

@siladu siladu siladu approved these changes

Assignees

@alexandratran alexandratran

@joaniefromtheblock joaniefromtheblock

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@joaniefromtheblock @non-fungible-nelson @alexandratran @siladu @bgravenorst