Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update limit for trace filter #1502

Merged
merged 11 commits into from
Feb 13, 2024
Merged

Update limit for trace filter #1502

merged 11 commits into from
Feb 13, 2024

Conversation

joaniefromtheblock
Copy link
Contributor

Closes #1487

@joaniefromtheblock
update limit for trace filter
25a7c21 
Signed-off-by: Joan Edwards <joan.edwards@consensys.net>
@joaniefromtheblock joaniefromtheblock requested a review from a team as a code owner February 1, 2024 20:56
@vercel Vercel
Copy link

vercel bot commented Feb 1, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
besu-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 13, 2024 6:18pm

Gabriel-Trintinalia
Gabriel-Trintinalia reviewed Feb 2, 2024
View reviewed changes
Copy link
Contributor

@Gabriel-Trintinalia Gabriel-Trintinalia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm

mjsmike62
mjsmike62 approved these changes Feb 2, 2024
View reviewed changes
Copy link
Contributor

@mjsmike62 mjsmike62 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

alexandratran
alexandratran requested changes Feb 2, 2024
View reviewed changes
Copy link
Contributor

@alexandratran alexandratran left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The --rpc-max-trace-filter-range option is a newly added command line option (you can examine the original product PR to see that it's been added to the source code). This means that you need to add documentation for it to the Besu command line options reference in the appropriate location on the page (after rpc-max-logs-range, since the options are alphabetized).

docs/public-networks/reference/api/index.md Outdated Show resolved Hide resolved
@joaniefromtheblock @alexandratran
Update docs/public-networks/reference/api/index.md
0139aec 
Co-authored-by: Alexandra Tran Carrillo <12214231+alexandratran@users.noreply.github.com>
Signed-off-by: Joan E <153745173+joaniefromtheblock@users.noreply.github.com>
@alexandratran alexandratran mentioned this pull request Feb 7, 2024
Merged
@joaniefromtheblock
move text
8818c28 
Signed-off-by: Joan E <153745173+joaniefromtheblock@users.noreply.github.com>
@joaniefromtheblock
add option
c3e626c 
Signed-off-by: Joan E <153745173+joaniefromtheblock@users.noreply.github.com>
@joaniefromtheblock
add link
fe5f5ee 
Signed-off-by: Joan E <153745173+joaniefromtheblock@users.noreply.github.com>
@joaniefromtheblock
add link for trace filter
1f2af00 
Signed-off-by: Joan E <153745173+joaniefromtheblock@users.noreply.github.com>
@joaniefromtheblock
Update language
3c8dda6 
Signed-off-by: Joan E <153745173+joaniefromtheblock@users.noreply.github.com>
@joaniefromtheblock
add for clarity
b955bcf 
Signed-off-by: Joan E <153745173+joaniefromtheblock@users.noreply.github.com>
alexandratran
alexandratran reviewed Feb 13, 2024
View reviewed changes
Copy link
Contributor

@alexandratran alexandratran left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks a lot better, I added some minor suggestions for clarity around this topic. Will approve once those are addressed.

docs/public-networks/reference/api/index.md Outdated Show resolved Hide resolved
docs/public-networks/reference/cli/options.md Outdated Show resolved Hide resolved
@joaniefromtheblock @alexandratran
Apply suggestions from code review
e97c9e8 
Co-authored-by: Alexandra Tran Carrillo <12214231+alexandratran@users.noreply.github.com>
Signed-off-by: Joan E <153745173+joaniefromtheblock@users.noreply.github.com>
@joaniefromtheblock
Copy link
Contributor Author

joaniefromtheblock commented Feb 13, 2024 •
edited
Loading

Thanks @alexandratran; I added your suggestions.

@alexandratran alexandratran merged commit a88fa90 into hyperledger:main Feb 13, 2024
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Gabriel-Trintinalia Gabriel-Trintinalia Gabriel-Trintinalia left review comments

@mjsmike62 mjsmike62 mjsmike62 approved these changes

@alexandratran alexandratran alexandratran approved these changes

Assignees

@joaniefromtheblock joaniefromtheblock

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

The trace-filter method in JSON-RPC API now has a default block range limit of 1000
4 participants
@joaniefromtheblock @alexandratran @Gabriel-Trintinalia @mjsmike62