Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add min gas option #1490

Merged
merged 5 commits into from
Feb 1, 2024
Merged

Add min gas option #1490

merged 5 commits into from
Feb 1, 2024

Conversation

joaniefromtheblock
Copy link
Contributor

Close #1467

@joaniefromtheblock
add min gas
cea2d7a 
Signed-off-by: Joan Edwards <joan.edwards@consensys.net>
@joaniefromtheblock joaniefromtheblock requested a review from a team as a code owner January 30, 2024 19:16
@vercel Vercel
Copy link

vercel bot commented Jan 30, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
besu-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 1, 2024 4:49pm

@joaniefromtheblock
add space
5094eee 
Signed-off-by: Joan E <153745173+joaniefromtheblock@users.noreply.github.com>
macfarla
macfarla reviewed Jan 30, 2024
View reviewed changes
Copy link
Contributor

@macfarla macfarla left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

default is 1000 so 2000 seems to be a sensible example suggestion

docs/public-networks/reference/cli/options.md Outdated Show resolved Hide resolved
docs/public-networks/reference/cli/options.md Outdated Show resolved Hide resolved
docs/public-networks/reference/cli/options.md Outdated Show resolved Hide resolved
docs/public-networks/reference/cli/options.md Outdated Show resolved Hide resolved
joaniefromtheblock and others added 2 commits January 31, 2024 13:23
@joaniefromtheblock @macfarla @fab-10
Apply suggestions from code review
d454555 
Co-authored-by: Sally MacFarlane <macfarla.github@gmail.com>
Co-authored-by: Fabio Di Fabio <fabio.difabio@consensys.net>
Signed-off-by: Joan E <153745173+joaniefromtheblock@users.noreply.github.com>
@joaniefromtheblock
Merge branch 'main' into 1467-txpoolmin
d4b3061
mjsmike62
mjsmike62 approved these changes Feb 1, 2024
View reviewed changes
Copy link
Contributor

@mjsmike62 mjsmike62 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@alexandratran alexandratran merged commit 88d3dd4 into hyperledger:main Feb 1, 2024
9 checks passed
@alexandratran alexandratran mentioned this pull request Feb 7, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@macfarla macfarla macfarla left review comments

@mjsmike62 mjsmike62 mjsmike62 approved these changes

@fab-10 fab-10 fab-10 approved these changes

@alexandratran alexandratran alexandratran approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Document tx-pool-min-gas-price option
5 participants
@joaniefromtheblock @macfarla @alexandratran @fab-10 @mjsmike62