Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add fast sync configuration note #1486

Merged
merged 7 commits into from
Jan 31, 2024
Merged

Add fast sync configuration note #1486

merged 7 commits into from
Jan 31, 2024

Conversation

joaniefromtheblock
Copy link
Contributor

@joaniefromtheblock joaniefromtheblock commented Jan 29, 2024 •
edited
Loading

Closes #1466

I am still investigating . I did not see this option in the ref docs, so added it back from a previous version. Will need to confirm that's correct

@joaniefromtheblock joaniefromtheblock requested a review from a team as a code owner January 29, 2024 19:42
@vercel Vercel
Copy link

vercel bot commented Jan 29, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
besu-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 30, 2024 9:10pm

@joaniefromtheblock
Copy link
Contributor Author

joaniefromtheblock commented Jan 29, 2024 •
edited
Loading

This is documented in the CLI, but not our docs. The --sync-min-peers option is documented instead, but this might be helpful for users.

bgravenorst
bgravenorst approved these changes Jan 30, 2024
View reviewed changes
Copy link
Contributor

@bgravenorst bgravenorst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor feedback.

docs/public-networks/reference/cli/options.md Outdated Show resolved Hide resolved
docs/public-networks/reference/cli/options.md Outdated Show resolved Hide resolved
joaniefromtheblock and others added 6 commits January 30, 2024 11:45
@joaniefromtheblock
Add fast sync configuration note
4bc6808 
Signed-off-by: Joan Edwards <joan.edwards@consensys.net>
@joaniefromtheblock
consistent text
edb5e14 
Signed-off-by: Joan E <153745173+joaniefromtheblock@users.noreply.github.com>
Signed-off-by: Joan Edwards <joan.edwards@consensys.net>
@joaniefromtheblock
consistency caps
ed6f040 
Signed-off-by: Joan E <153745173+joaniefromtheblock@users.noreply.github.com>
Signed-off-by: Joan Edwards <joan.edwards@consensys.net>
@joaniefromtheblock
consolidate naming
6fbd573 
Signed-off-by: Joan Edwards <joan.edwards@consensys.net>
@joaniefromtheblock
reorder
7617f60 
Signed-off-by: Joan E <153745173+joaniefromtheblock@users.noreply.github.com>
Signed-off-by: Joan Edwards <joan.edwards@consensys.net>
@joaniefromtheblock
apply suggestions
25510bc 
Signed-off-by: Joan Edwards <joan.edwards@consensys.net>
@joaniefromtheblock @alexandratran
Add backticks
f1c823a 
Co-authored-by: Alexandra Tran Carrillo <12214231+alexandratran@users.noreply.github.com>
Signed-off-by: Joan E <153745173+joaniefromtheblock@users.noreply.github.com>
@joaniefromtheblock
Copy link
Contributor Author

@alexandratran @bgravenorst is this okay to merge?

@alexandratran alexandratran merged commit bc1c6bd into hyperledger:main Jan 31, 2024
9 checks passed
@alexandratran alexandratran mentioned this pull request Feb 7, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alexandratran alexandratran alexandratran left review comments

@bgravenorst bgravenorst bgravenorst approved these changes

@jflo jflo jflo approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add note about fast-sync-min-peers
4 participants
@joaniefromtheblock @jflo @alexandratran @bgravenorst