Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added CLI option and API methods for min priority fee #1452

Merged
merged 3 commits into from
Nov 22, 2023

Conversation

MadelineMurray
Copy link
Contributor

Fixes #1434

Signed-off-by: madelinemurray <madeline.murray@consensys.net>
@MadelineMurray MadelineMurray requested a review from a team as a code owner November 22, 2023 01:59
@MadelineMurray
Copy link
Contributor Author

Also fixes #1438

Copy link

vercel bot commented Nov 22, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
besu-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 22, 2023 7:45pm

Copy link
Contributor

@alexandratran alexandratran left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some edits, lgtm.

docs/public-networks/reference/api/index.md Outdated Show resolved Hide resolved
docs/public-networks/reference/api/index.md Outdated Show resolved Hide resolved
docs/public-networks/reference/api/index.md Outdated Show resolved Hide resolved
docs/public-networks/reference/cli/options.md Outdated Show resolved Hide resolved
docs/public-networks/reference/cli/options.md Outdated Show resolved Hide resolved
Signed-off-by: Alexandra Tran Carrillo <12214231+alexandratran@users.noreply.github.com>
@alexandratran alexandratran merged commit 08b830e into hyperledger:main Nov 22, 2023
8 checks passed
The `MINER` API methods allow you to control the node’s mining operation.
The `MINER` API methods allow you to control:

* The node’s mining operation.
Copy link
Contributor

@mjsmike62 mjsmike62 Nov 28, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"The" article is not needed.

Usually, inanimate objects don't take a possessive.

Copy link
Contributor

@mjsmike62 mjsmike62 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One small, suggested edit. But LGTM.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Document the JSON-RPC methods: miner_setMinPriorityFee and miner_getMinPriorityFee
4 participants