Update config for tx-pool-limit-by-account-percentage on pub nets, co…

…nsider moving to both sides (#1256)

* Update config for tx-pool-limit-by-account-percentage

This updates the tx-pool-limit to the correct name for the parameter and provides a word of caution. Suggest that we copy this over to the private network side and call it out as well until we have a better parameterization default. We may be changing this shortly on Mainnet. I will ask @fab-10 to tag the docs team when he finishes his new transaction pool work. 

Signed-off-by: Matt Nelson <85905982+non-fungible-nelson@users.noreply.github.com>

* edit PR content

Signed-off-by: Alexandra Tran <alexandra.tran@consensys.net>

* fabio suggestions

Co-authored-by: Fabio Di Fabio <fabio.difabio@consensys.net>
Signed-off-by: Matt Nelson <85905982+non-fungible-nelson@users.noreply.github.com>

* more fabio suggestions

Co-authored-by: Fabio Di Fabio <fabio.difabio@consensys.net>
Signed-off-by: Matt Nelson <85905982+non-fungible-nelson@users.noreply.github.com>

* fix spell check

Signed-off-by: Alexandra Tran <alexandra.tran@consensys.net>

---------

Signed-off-by: Matt Nelson <85905982+non-fungible-nelson@users.noreply.github.com>
Signed-off-by: Alexandra Tran <alexandra.tran@consensys.net>
Co-authored-by: Alexandra Tran <alexandra.tran@consensys.net>
Co-authored-by: Alexandra Tran Carrillo <12214231+alexandratran@users.noreply.github.com>
Co-authored-by: Fabio Di Fabio <fabio.difabio@consensys.net>

docs/private-networks/get-started/start-node.md

@@ -114,4 +114,10 @@ besu --genesis-file=<path>/genesis.json --data-path=<data-path> --rpc-http-enabl
 ```
 
 Where `<data-path>` is the path to the directory to save the chain data to.
-Ensure you configure a peer discovery method, such as [bootnodes](../how-to/configure/bootnodes.md)
+Ensure you configure a peer discovery method, such as [bootnodes](../how-to/configure/bootnodes.md).
+
+!!! note
+    You might need to set
+    [`--tx-pool-limit-by-account-percentage`](../../public-networks/reference/cli/options.md#tx-pool-limit-by-account-percentage)
+    to 1.
+    The default value is suitable for Mainnet, but may cause issues on private networks.

docs/public-networks/reference/cli/options.md

@@ -3331,34 +3331,42 @@ Use the [`miner_changeTargetGasLimit`](../api/index.md#miner_changetargetgaslimi
 the `target-gas-limit` while Besu is running. Alternatively restart Besu with an updated
 `target-gas-limit` value.
 
-### `tx-pool-future-max-by-account`
+### `tx-pool-limit-by-account-percentage`
 
 === "Syntax"
 
     ```bash
-    --tx-pool-future-max-by-account=<INTEGER>
+    --tx-pool-limit-by-account-percentage=<DOUBLE>
     ```
 
 === "Example"
 
     ```bash
-    --tx-pool-future-max-by-account=100
+    --tx-pool-limit-by-account-percentage=0.1
     ```
 
 === "Environment variable"
 
     ```bash
-    BESU_TX_POOL_FUTURE_MAX_BY_ACCOUNT=100
+    BESU_TX_POOL_LIMIT_BY_ACCOUNT_PERCENTAGE=0.1
     ```
 
 === "Configuration file"
 
     ```bash
-    tx-pool-future-max-by-account="100"
+    tx-pool-limit-by-account-percentage=0.4
     ```
 
-The maximum number of future transactions kept in the transaction pool, per account.
-The default is 64.
+The maximum percentage of future transactions kept in the transaction pool, per account.
+Accepted values are in the range (0–1].
+The default is .001 or 0.1% of transactions from a single account to be kept in the pool.
+
+!!! warning
+    The default value is often unsuitable for [private networks](../../../private-networks/index.md).
+    This feature mitigates future-nonce transactions from filling the pool without ever being
+    executable by Besu.
+    This is important for Mainnet, but may cause issues on private networks.
+    Please update this value or set to 1 if you know the nodes gossiping transactions in your network.
 
 ### `tx-pool-max-size`