Skip to content

Commit

Permalink
fix: optimize using proper token, combine and optimize skip ci tag (#463
Browse files Browse the repository at this point in the history
)

### Description

<!--
Summary of change.
Example: Add sepolia chain
-->

- Update `optimize-svg.yml` with proper write permission token
- Fix `[skip-ci]` -> `[skip ci]` tag for commits in file
`optimize-svg.yml` and `combine.yml`

### Backward compatibility

<!--
Are these changes backward compatible? Note that additions are backwards
compatible.

Yes/No
-->

Yes

### Testing

<!--
Have any new metadata configs and deployment addresses been used with
any Hyperlane tooling, such as the CLI?
-->
Manual
  • Loading branch information
Xaroz authored Jan 7, 2025
1 parent 9a11b8b commit d01becf
Show file tree
Hide file tree
Showing 2 changed files with 6 additions and 4 deletions.
2 changes: 1 addition & 1 deletion .github/workflows/combine.yml
Original file line number Diff line number Diff line change
Expand Up @@ -58,7 +58,7 @@ jobs:
CHANGES=$(git status -s)
if [[ ! -z $CHANGES ]]; then
git add .
git commit -m "Update chain metadata and address files [skip-ci]"
git commit -m "Update chain metadata and address files [skip ci]"
git push
else
echo "No changes to commit."
Expand Down
8 changes: 5 additions & 3 deletions .github/workflows/optimize-svg.yml
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,9 @@ jobs:
- uses: actions/checkout@v4
with:
ref: ${{ github.head_ref || 'main' }}
token: ${{ secrets.GITHUB_TOKEN }}
# This action secret contains a fine-grained personal access token with permissions to read/write repo content
# It is necessary because the default GITHUB_TOKEN cannot re-trigger workflows after pushing
token: ${{ secrets.COMBINE_CI_TOKEN || secrets.GITHUB_TOKEN }}

- uses: actions/cache@v4
with:
Expand All @@ -38,7 +40,7 @@ jobs:
with:
node-version: 20

- name: validate-optimize-svgs
- name: optimize-svgs
run: |
node ./scripts/optimize-svg.js
Expand All @@ -52,7 +54,7 @@ jobs:
CHANGES=$(git status -s)
if [[ ! -z $CHANGES ]]; then
git add .
git commit -m "Optimize SVG files [skip-ci]"
git commit -m "Optimize SVG files [skip ci]"
git push
else
echo "No changes to commit."
Expand Down

0 comments on commit d01becf

Please sign in to comment.