Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test(cli): warp commands e2e tests #5121

Open
wants to merge 35 commits into
base: main
Choose a base branch
from
Open

Conversation

xeno097
Copy link
Contributor

@xeno097 xeno097 commented Jan 7, 2025

Description

This PR tries to e2e test multiple use cases with warp commands to ensure that future changes that might break or change the commands' behavior are detected early.

Drive-by changes

  • fixes skipConfirmation propagation in signer strategy code
  • move the warp e2e tests into the test/warp folder

Related issues

Backward compatibility

  • YES

Testing

  • Manual
  • E2E

Copy link

changeset-bot bot commented Jan 7, 2025

⚠️ No Changeset found

Latest commit: 019d8d2

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link

codecov bot commented Jan 7, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 77.53%. Comparing base (9574b1b) to head (019d8d2).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #5121   +/-   ##
=======================================
  Coverage   77.53%   77.53%           
=======================================
  Files         103      103           
  Lines        2110     2110           
  Branches      190      190           
=======================================
  Hits         1636     1636           
  Misses        453      453           
  Partials       21       21           
Components Coverage Δ
core 87.80% <ø> (ø)
hooks 79.39% <ø> (ø)
isms 83.68% <ø> (ø)
token 91.27% <ø> (ø)
middlewares 79.80% <ø> (ø)

@xeno097 xeno097 requested a review from paulbalaji January 9, 2025 16:46
wbtc-ethereum-form.yaml Outdated Show resolved Hide resolved
Comment on lines 55 to 57
return `${REGISTRY_PATH}/deployments/warp_routes/${tokenSymbol.toUpperCase()}/${chains.join(
'-',
)}-config.yaml`;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the createWarpRouteConfigId and BaseRegistry.getWarpRoutesPath functions in the registry package can help you reduce duplication with Registry code here

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I haven't reused the BaseRegistry.getWarpRoutesPath because it is marked as protected. Thanks for the createWarpRouteConfigId suggestion 🔥

@xeno097 xeno097 requested a review from jmrossy January 14, 2025 20:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: In Review
Development

Successfully merging this pull request may close these issues.

2 participants