Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Correct logger formate issues in Paligemma model. #35474

Closed
wants to merge 1 commit into from

Conversation

marko1616
Copy link

@marko1616 marko1616 commented Jan 1, 2025

What does this PR do?

Before submitting

  • This PR fixes a typo or improves the docs (you can dismiss the other checks if that's the case).
  • Did you read the contributor guideline,
    Pull Request section?
  • Was this discussed/approved via a Github issue or the forum? Please add a link
    to it if that's the case.
  • Did you make sure to update the documentation with your changes? Here are the
    documentation guidelines, and
    here are tips on formatting docstrings.
  • Did you write any new necessary tests?

Description

The logger.warning_once function, if given two arguments, will interpret the first argument as a format string and the second as its arguments. To prevent this unintended string formatting, we use string literal concatenation to pass a single string argument. See python docs and other code.
Any way this message also need a change here because the current verison is 4.47.1 now.

Who can review?

@amyeroberts
@qubvel

Thanks to those who review this PR.

@marko1616
Copy link
Author

Fixed at #35486

@marko1616 marko1616 closed this Jan 2, 2025
@marko1616 marko1616 deleted the patch-1 branch January 2, 2025 12:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant