Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ModernBert: reuse GemmaRotaryEmbedding via modular + Integration tests #35459

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

tomaarsen
Copy link
Member

What does this PR do?

  1. Add integration tests with the now-released checkpoint + 2 checkpoints under hf-internal-testing (thanks @xenova !)
  2. Reuse GemmaRotaryEmbedding via modular functionality

Note that I based the expected values from the integration tests on the main implementation, not the RotaryEmbedding refactored implementation. In short: the test passes indicate that the refactor preserves the performance.

This is the refactor that I promised earlier offline.

Before submitting

  • This PR fixes a typo or improves the docs (you can dismiss the other checks if that's the case).
  • Did you read the contributor guideline,
    Pull Request section?
  • Was this discussed/approved via a Github issue or the forum? Please add a link
    to it if that's the case.
  • Did you make sure to update the documentation with your changes? Here are the
    documentation guidelines, and
    here are tips on formatting docstrings.
  • Did you write any new necessary tests?

Who can review?

@ArthurZucker

cc @warner-benjamin

  • Tom Aarsen

@HuggingFaceDocBuilderDev

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update.

Copy link
Contributor

@warner-benjamin warner-benjamin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants