[Proposal] Simplifying our internal cargo dependencies. #1529
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LaurentMazare
approved these changes
Jan 7, 2024
|
Looks certainly simpler than using sed as I was doing for the updates but the versions are also not "pinned" anymore in the manifest compared to the old version. That said I'm not sure there was an upside to doing so so let's merge this and see how it goes :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
-> Move all our packages inside the workspace dependencies, so all folders (except the packages not in the workspace) can just use
workspace = true. That removes the version number from a lot of places, so there is a single number for the entire workspace in the rootCargo.toml.Packages outside the workspace (flash, kernels, metal-kernels, onnx) still use path dependencies.