Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add super chlorination controls to ScreenLogic #106223

Closed
wants to merge 6 commits into from

Conversation

dieselrabbit
Copy link
Contributor

@dieselrabbit dieselrabbit commented Dec 22, 2023

Proposed change

  • Add super chlorination configuration entities if chlorinator is present:
    • switch entity to start and stop super chlorination
    • number to set number of hours to run super chlorination when started
  • Refactors ScreenLogicCircuitEntity to be more generic
    • Used as base for future switches
  • All chlorinator configuration entities default to disabled if IntelliChem is installed. (IntelliChem is in control of chlorinator if present)
    • Will not disable existing chlorinator entities

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • I have followed the perfect PR recommendations
  • The code has been formatted using Ruff (ruff format homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
  • Untested files have been added to .coveragerc.

To help with the load of incoming pull requests:

@home-assistant
Copy link

Hey there @bdraco, mind taking a look at this pull request as it has been labeled with an integration (screenlogic) you are listed as a code owner for? Thanks!

Code owner commands

Code owners of screenlogic can trigger bot actions by commenting:

  • @home-assistant close Closes the pull request.
  • @home-assistant rename Awesome new title Renames the pull request.
  • @home-assistant reopen Reopen the pull request.
  • @home-assistant unassign screenlogic Removes the current integration label and assignees on the pull request, add the integration domain after the command.
  • @home-assistant add-label needs-more-information Add a label (needs-more-information, problem in dependency, problem in custom component) to the pull request.
  • @home-assistant remove-label needs-more-information Remove a label (needs-more-information, problem in dependency, problem in custom component) on the pull request.

@dieselrabbit dieselrabbit marked this pull request as ready for review December 22, 2023 23:37
@dieselrabbit dieselrabbit requested a review from bdraco as a code owner December 22, 2023 23:37
@bdraco
Copy link
Member

bdraco commented Dec 23, 2023

Would you please split the base entity changes into another PR. Thanks

@dieselrabbit dieselrabbit marked this pull request as draft December 23, 2023 21:18
@dieselrabbit
Copy link
Contributor Author

Also feel like I should split out the test data updates that should have come with the last lib bump.

@dieselrabbit
Copy link
Contributor Author

I'm going to remake this PR based on the new break-out of the shared code.

@github-actions github-actions bot locked and limited conversation to collaborators Dec 25, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Super Chlorinate
2 participants