-
-
Notifications
You must be signed in to change notification settings - Fork 31.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add super chlorination controls to ScreenLogic #106223
Conversation
Hey there @bdraco, mind taking a look at this pull request as it has been labeled with an integration ( Code owner commandsCode owners of
|
Would you please split the base entity changes into another PR. Thanks |
Also feel like I should split out the test data updates that should have come with the last lib bump. |
I'm going to remake this PR based on the new break-out of the shared code. |
Proposed change
switch
entity to start and stop super chlorinationnumber
to set number of hours to run super chlorination when startedScreenLogicCircuitEntity
to be more genericType of change
Additional information
Checklist
ruff format homeassistant tests
)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest
.requirements_all.txt
.Updated by running
python3 -m script.gen_requirements_all
..coveragerc
.To help with the load of incoming pull requests: