Fix header link text mismatch for accessibility #412
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue:
The header link is named "HIDIVE Lab" to sighted users but "Home" to screen reader users.
The accessible name of any interactive element should contain its visible text label. Using two different names for a single page element can create a confusing user experience for assistive technology users. For example, speech-input users may have difficulty activating a control if the label displayed on-screen does not match its accessible name.
Fix:
In the header.html template, the header link's
aria-labelattribute is given the same dynamically generated value as its link text, so that all users are provided the same header link name.