Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add defunctionalizer prototype #185

Merged
merged 22 commits into from
Oct 12, 2023
Merged

Add defunctionalizer prototype #185

merged 22 commits into from
Oct 12, 2023

Conversation

HarrisL2
Copy link
Contributor

Adapted from #159.

@LPTK LPTK marked this pull request as draft October 4, 2023 12:54
@HarrisL2 HarrisL2 marked this pull request as ready for review October 4, 2023 16:08
LPTK
LPTK reviewed Oct 5, 2023
View reviewed changes
Copy link
Contributor

@LPTK LPTK left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some of these comments concern code from @yuankeyu.

@yuankeyu, could you please join the discussion and address the relevant comments?

compiler/shared/main/scala/mlscript/compiler/ClassLifter.scala Show resolved Hide resolved
compiler/shared/main/scala/mlscript/compiler/syntax.scala Outdated Show resolved Hide resolved
compiler/shared/main/scala/mlscript/compiler/printer/ExprPrinter.scala Outdated Show resolved Hide resolved
compiler/shared/main/scala/mlscript/compiler/mono/Monomorph.scala Outdated Show resolved Hide resolved
compiler/shared/test/diff/LambLift.mls Outdated Show resolved Hide resolved
compiler/shared/test/diff/mono.mls Outdated Show resolved Hide resolved
compiler/shared/test/diff/mono.mls Outdated Show resolved Hide resolved
compiler/shared/test/diff/mono.mls Outdated Show resolved Hide resolved
compiler/shared/test/diff/mono.mls Outdated Show resolved Hide resolved
@LPTK LPTK mentioned this pull request Oct 5, 2023
Closed
@LPTK LPTK changed the title Updated Defunctionalizer Prototype to new defs Add defunctionalizer prototype Oct 5, 2023
@LPTK LPTK merged commit f5e9826 into hkust-taco:new-definition-typing Oct 12, 2023
@HarrisL2 HarrisL2 deleted the specializing branch October 12, 2023 16:18
floatshadow added a commit to floatshadow/mlscript that referenced this pull request Oct 22, 2023
@floatshadow
Revert "Add defunctionalizer prototype (hkust-taco#185)"
83d975e 
This reverts commit f5e9826.

Monomorphizer Expr class has name conflict with graph-ir
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yuankeyu yuankeyu yuankeyu left review comments

@LPTK LPTK LPTK left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@HarrisL2 @LPTK @yuankeyu