Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add .d.ts Tests, Literal Type Parsing, and Variables Parsing #146

Merged
merged 20 commits into from
Oct 28, 2022
Merged

Add .d.ts Tests, Literal Type Parsing, and Variables Parsing #146

merged 20 commits into from
Oct 28, 2022

Conversation

NeilKleistGao
Copy link
Member

@NeilKleistGao NeilKleistGao commented Oct 12, 2022 •
edited
Loading

Related Issue: #134

A function-like variable is like this:

const some = <A>(a: A): Option<A> => ({ _tag: 'Some', value: a })

Also:

  • Reorder ts2mls tests list

@NeilKleistGao NeilKleistGao changed the title Add .d.ts Tests and Fix Function Like Variables Parsing Add .d.ts Tests, Literal Type Parsing, and Fix Arrow Functions/Object Literal Parsing Oct 13, 2022
@NeilKleistGao
Copy link
Member Author

NeilKleistGao commented Oct 14, 2022 •
edited
Loading

I think features are ok so far. But the code is quite ugly. Let me find a better way to implement it. 😶‍🌫️
OK now it is better I guess.

@NeilKleistGao NeilKleistGao changed the title Add .d.ts Tests, Literal Type Parsing, and Fix Arrow Functions/Object Literal Parsing Add .d.ts Tests, Literal Type Parsing, and Variables Parsing Oct 17, 2022
@NeilKleistGao NeilKleistGao marked this pull request as ready for review October 20, 2022 02:19
LPTK
LPTK approved these changes Oct 28, 2022
View reviewed changes
Copy link
Contributor

@LPTK LPTK left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@LPTK LPTK merged commit 6de2043 into hkust-taco:mlscript Oct 28, 2022
@NeilKleistGao NeilKleistGao deleted the dd branch August 30, 2023 01:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LPTK LPTK LPTK approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@NeilKleistGao @LPTK