Remove deprecated interfaces #385
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
schneems
force-pushed
the
schneems/remove-deprecated-build-output
branch
from
c8dfad1 to
2147e82
Compare
edmorley
approved these changes
Jan 13, 2025
This output came from CI:
```
** Invoke assets:precompile (first_time)
START RAKE TEST OUTPUT
$ echo $PATH
** Execute assets:precompile
/layers/heroku_ruby/gems/ruby/3.2.0/bin:/workspace/bin:/layers/heroku_ruby/gems/bin:/layers/heroku_ruby/bundler/bin:/layers/heroku_ruby/binruby/bin:/usr/local/sbin:/usr/local/bin:/usr/sbin:/usr/bin:/sbin:/bin
$ which -a rake
/layers/heroku_ruby/gems/ruby/3.2.0/bin/rake
/workspace/bin/rake
/layers/heroku_ruby/gems/bin/rake
/layers/heroku_ruby/binruby/bin/rake
/usr/bin/rake
/bin/rake
$ which -a ruby
/layers/heroku_ruby/binruby/bin/ruby
/usr/bin/ruby
/bin/ruby
END RAKE TEST OUTPUT
```
Which is ordered incorrectly. This forces stdout and stderr to emit immediately instead of buffering.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With the nodejs updates I believe everyone is off of the output module from commons and we can safely remove it.