Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Reentrancy Vulnerability in executeTransaction #81

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Fix Reentrancy Vulnerability in executeTransaction #81

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 14 additions & 4 deletions helix-contract/contracts/dao/MultiSigWallet.sol
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -230,12 +230,22 @@ contract MultiSigWallet {
{
if (isConfirmed(transactionId)) {
Transaction storage txn = transactions[transactionId];
txn.executed = true;
if (external_call(txn.destination, txn.value, txn.data.length, txn.data))
txn.executed = true; // Set executed flag before external call to prevent reentrancy
bool success = false;

if (txn.data.length == 0) {
// For simple ETH transfer
success = payable(txn.destination).send(txn.value);
} else {
// For other calls, use low-level call with reentrancy check
(success, ) = txn.destination.call{value: txn.value}(txn.data);
}

if (success) {
emit Execution(transactionId);
else {
} else {
emit ExecutionFailure(transactionId);
txn.executed = false;
txn.executed = false; // Revert executed flag if the transaction failed
}
}
}
Expand Down