Enable -fexpose-all-unfoldings
#357
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This allows us to remove a good amount of CPP and hacks.
Stackage snapshots for GHC 8.2 use hashable-1.2.7.0, so this shouldn't cause any problems.
This allows us to reliably expose unfoldings for all exposed functions, instead of only those that are marked INLINABLE. Also remove -fwarn-tabs which is enabled by default now.
|
I will finish this after merging #355. |
…to silence a warning.
|
This will definitely do something. Let's make sure it's something good. |
|
Apparently https://gitlab.haskell.org/ghc/ghc/-/issues/21715#note_437347 I probably won't work on this further until I have a better understanding of the implications. |
|
I also wasn't aware of this difference. I've made a note of it for the handbook. I don't think |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows us to reliably expose unfoldings for all exposed functions, instead of only those that are marked
INLINABLE.Also remove
-fwarn-tabswhich is enabled by default now.