Add ns related funcs #80
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Vicente-Cheng
force-pushed
the
add-ns-related-funcs
branch
3 times, most recently
from
2128cae to
b18fdf4
Compare
|
Did we see any issue with importing |
|
Because of various improvements in Longhorn Common Library (after v1.6.0), some related functions have been removed. We only need a few parts, so I prefer to maintain ourselves. |
tserong
reviewed
Jan 30, 2024
Vicente-Cheng
force-pushed
the
add-ns-related-funcs
branch
from
b18fdf4 to
7828d38
Compare
Vicente-Cheng
force-pushed
the
add-ns-related-funcs
branch
from
7828d38 to
bedbc41
Compare
- that we can drop some dependency Signed-off-by: Vicente Cheng <vicente.cheng@suse.com>
Signed-off-by: Vicente Cheng <vicente.cheng@suse.com>
Signed-off-by: Vicente Cheng <vicente.cheng@suse.com>
Vicente-Cheng
force-pushed
the
add-ns-related-funcs
branch
from
3f0c037 to
43174e6
Compare
bk201
approved these changes
Jan 30, 2024
tserong
approved these changes
Jan 31, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem:
Move ns related functions locally instead of extra packages
Solution:
Implement our own ns related ns functions
Related Issue:
Test plan:
Make sure everything will be fine after that.