Add new validator when adding bd #155
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Vicente-Cheng
force-pushed
the
add-new-validator-when-adding-bd
branch
from
f70f894 to
7754150
Compare
Signed-off-by: Vicente Cheng <vicente.cheng@suse.com>
Vicente-Cheng
force-pushed
the
add-new-validator-when-adding-bd
branch
2 times, most recently
from
ae652dd to
1a6c1e7
Compare
tserong
approved these changes
Oct 16, 2024
Vicente-Cheng
force-pushed
the
add-new-validator-when-adding-bd
branch
from
1a6c1e7 to
d4eefaf
Compare
tserong
approved these changes
Oct 16, 2024
- simpify the vg management and offload to user on v1.4 Signed-off-by: Vicente Cheng <vicente.cheng@suse.com>
Vicente-Cheng
force-pushed
the
add-new-validator-when-adding-bd
branch
from
d4eefaf to
331ac23
Compare
- sync the `Spec.Provision` and `Spec.Filesystem.Provisioned` Signed-off-by: Vicente Cheng <vicente.cheng@suse.com>
Vicente-Cheng
force-pushed
the
add-new-validator-when-adding-bd
branch
from
331ac23 to
a4901fc
Compare
tserong
approved these changes
Oct 17, 2024
bk201
approved these changes
Oct 17, 2024
|
@Mergifyio backport v0.7.x |
✅ Backports have been created
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem:
Because volume group management needs to consider many factors, we decided to offload this behavior to the user and block operations, like adding a new block device to the volume group.
Solution:
We need to check when trying to add a new blockdevice into volume group
Related Issue:
Test plan: