fix: set LHv2 DiskDriver to "auto" if unset (backport #152) #154
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![mergify[bot]](https://avatars.githubusercontent.com/in/10562?s=60&v=4){kind=small}
We need to force DiskDriver to "auto" if it's not explicitly set, because Longhorn also does that internally. If we don't do this, the subsequent reflect.DeepEqual() in LonghornV2Provisioner.Update() will always fail because we have an empty string, but the LHN CR will have it set to "auto" which results in a weird resync loop. Related issue: harvester/harvester#6709 Signed-off-by: Tim Serong <tserong@suse.com> (cherry picked from commit 09e26bc)
Vicente-Cheng
approved these changes
Oct 11, 2024
|
Before #153, the CI failure is expected. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem:
We need to force DiskDriver to "auto" if it's not explicitly set, because Longhorn also does that internally. If we don't do this, the subsequent
reflect.DeepEqual()inLonghornV2Provisioner.Update()will always fail because we have an empty string, but the LHN CR will have it set to "auto" which results in a weird resync loop.Solution:
This PR.
Related Issue:
harvester/harvester#6709
Test plan:
Add an LHv2 disk. Verify we don't see the errors mentioned in the related issue.
This is an automatic backport of pull request #152 done by [Mergify](https://mergify.com).