Fix two issues encountered when testing LHv2 provisioning (backport #142) #144
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![mergify[bot]](https://avatars.githubusercontent.com/in/10562?s=60&v=4){kind=small}
Previously, every call to LonghornV2Provisioner.Update() would trigger an udpate of the Longhorn node object and a requeue even if nothing had changed. This resulted in the BD getting suck with the AddedToNode condition set to False and an error: admission webhook "validator.longhorn.io" denied the request: spec and status of disks on node harvester-node-0 are being syncing and please retry later. Now we only try to sync if the DiskDriver has actually changed, and everything behaves correctly. Signed-off-by: Tim Serong <tserong@suse.com> (cherry picked from commit 77c4672)
When Longhorn V2 volumes are created and attached to VMs, they appear on Harvester hosts as /dev/dm-* and /dev/nvme* devices. This is problematic, because NDM thinks those things are actual disks and creates BD CRs from them. This change is a bit of a hack until I finish the work for harvester/harvester#5059. Signed-off-by: Tim Serong <tserong@suse.com> (cherry picked from commit 05ca4c7)
Vicente-Cheng
approved these changes
Sep 27, 2024
bk201
approved these changes
Sep 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem:
/dev/dm-*and/dev/nvme*devices on the host. NDM sees these and thinks they're real disks, and then creates new BD CRs from those devices.Solution:
reflect.DeepEqual()to avoid unnecessary updates and resultant weird state./dev/dm-devices inApplyExcludeFiltersForDisk().Note: I intend to handle this more cleanly later as part of harvester/harvester#5059
Related Issue:
harvester/harvester#5274
Test plan:
N/A
This is an automatic backport of pull request #142 done by [Mergify](https://mergify.com).